[SPARK-22464] [SQL] No pushdown for Hive metastore partition predicates containing null-safe equality #19682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #83531 has finished for PR 19682 at commit
|
cloud-fan
reviewed
Nov 7, 2017
| * | ||
| * null-safe equality is not supported by Hive metastore partition predicate pushdown | ||
| */ | ||
| object OperatorsInMetastorePartitionFPD { |
There was a problem hiding this comment.
This name looks weird... maybe just SpecialBinaryComparison and explain the detail in the document.
|
Test build #83535 has finished for PR 19682 at commit
|
|
Test build #83552 has finished for PR 19682 at commit
|
|
thanks, merging to master! |
|
can you send a new PR for 2.2? thanks! |
|
Thanks for the fix! |
gatorsmile
added a commit
to gatorsmile/spark
that referenced
this pull request
Nov 11, 2017
…s containing null-safe equality ## What changes were proposed in this pull request? `<=>` is not supported by Hive metastore partition predicate pushdown. We should not push down it to Hive metastore when they are be using in partition predicates. ## How was this patch tested? Added a test case Author: gatorsmile <gatorsmile@gmail.com> Closes apache#19682 from gatorsmile/fixLimitPushDown. # Conflicts: # sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala # sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
<=>is not supported by Hive metastore partition predicate pushdown. We should not push down it to Hive metastore when they are be using in partition predicates.How was this patch tested?
Added a test case