Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-22483][CORE]. Exposing java.nio bufferedPool memory metrics to Metric System #19709

Closed
wants to merge 1 commit into from

Conversation

vundela
Copy link

@vundela vundela commented Nov 9, 2017

What changes were proposed in this pull request?

Adds java.nio bufferedPool memory metrics to metrics system which includes both direct and mapped memory.

How was this patch tested?

Manually tested and checked direct and mapped memory metrics too available in metrics system using Console sink.

Here is the sample console output

application_1509655862825_0016.2.jvm.direct.capacity
value = 19497
application_1509655862825_0016.2.jvm.direct.count
value = 6
application_1509655862825_0016.2.jvm.direct.used
value = 19498

application_1509655862825_0016.2.jvm.mapped.capacity
value = 0
application_1509655862825_0016.2.jvm.mapped.count
value = 0
application_1509655862825_0016.2.jvm.mapped.used
value = 0

@vanzin
Copy link
Contributor

vanzin commented Nov 9, 2017

ok to test

@SparkQA
Copy link

SparkQA commented Nov 9, 2017

Test build #83649 has finished for PR 19709 at commit 2a0b281.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vundela
Copy link
Author

vundela commented Nov 9, 2017

retest this please.

@SparkQA
Copy link

SparkQA commented Nov 9, 2017

Test build #83650 has finished for PR 19709 at commit 45925dc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor

vanzin commented Nov 10, 2017

LGTM, merging to master.

@asfgit asfgit closed this in 9eb7096 Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants