[SPARK-22471][SQL] SQLListener consumes much memory causing OutOfMemoryError #19711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
vanzin
reviewed
Nov 9, 2017
| @@ -207,6 +210,14 @@ class SQLListener(conf: SparkConf) extends SparkListener with Logging { | |||
| } | |||
| } | |||
|
|
|||
| override def onStageCompleted(stageCompleted: SparkListenerStageCompleted): Unit = { | |||
|
Test build #83656 has finished for PR 19711 at commit
|
jerryshao
reviewed
Nov 10, 2017
| @@ -113,7 +116,7 @@ class SQLListener(conf: SparkConf) extends SparkListener with Logging { | |||
| */ | |||
| private val _jobIdToExecutionId = mutable.HashMap[Long, Long]() | |||
|
|
|||
| private val _stageIdToStageMetrics = mutable.HashMap[Long, SQLStageMetrics]() | |||
| private val _stageIdToStageMetrics = mutable.LinkedHashMap[Long, SQLStageMetrics]() | |||
There was a problem hiding this comment.
Maybe we can use Java's LinkedHashMap and override removeEldestEntry to what we want.
There was a problem hiding this comment.
removeEldestEntry is a protected method.
There was a problem hiding this comment.
Java's LinkedHashMap can be overridden with a custom implementation of removeEldestEntry, that will save the codes done below. It is not the user who call this removeEldestEntry...
|
Test build #83680 has finished for PR 19711 at commit
|
|
Retest this please. |
|
Test build #83682 has finished for PR 19711 at commit
|
|
Corrupted build node? |
|
Retest this please. |
1 similar comment
|
Retest this please. |
|
Test build #83805 has finished for PR 19711 at commit
|
|
LGTM, merging to 2.2. |
asfgit
pushed a commit
that referenced
this pull request
Nov 13, 2017
…ryError ## What changes were proposed in this pull request? This PR addresses the issue [SPARK-22471](https://issues.apache.org/jira/browse/SPARK-22471). The modified version of `SQLListener` respects the setting `spark.ui.retainedStages` and keeps the number of the tracked stages within the specified limit. The hash map `_stageIdToStageMetrics` does not outgrow the limit, hence overall memory consumption does not grow with time anymore. A 2.2-compatible fix. Maybe incompatible with 2.3 due to #19681. ## How was this patch tested? A new unit test covers this fix - see `SQLListenerMemorySuite.scala`. Author: Arseniy Tashoyan <tashoyan@gmail.com> Closes #19711 from tashoyan/SPARK-22471-branch-2.2.
|
@tashoyan please close this since github doesn't do it automatically for branches. |
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
…ryError ## What changes were proposed in this pull request? This PR addresses the issue [SPARK-22471](https://issues.apache.org/jira/browse/SPARK-22471). The modified version of `SQLListener` respects the setting `spark.ui.retainedStages` and keeps the number of the tracked stages within the specified limit. The hash map `_stageIdToStageMetrics` does not outgrow the limit, hence overall memory consumption does not grow with time anymore. A 2.2-compatible fix. Maybe incompatible with 2.3 due to apache#19681. ## How was this patch tested? A new unit test covers this fix - see `SQLListenerMemorySuite.scala`. Author: Arseniy Tashoyan <tashoyan@gmail.com> Closes apache#19711 from tashoyan/SPARK-22471-branch-2.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR addresses the issue SPARK-22471. The modified version of
SQLListenerrespects the settingspark.ui.retainedStagesand keeps the number of the tracked stages within the specified limit. The hash map_stageIdToStageMetricsdoes not outgrow the limit, hence overall memory consumption does not grow with time anymore.A 2.2-compatible fix. Maybe incompatible with 2.3 due to #19681.
How was this patch tested?
A new unit test covers this fix - see
SQLListenerMemorySuite.scala.