-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPARK-22373 Bump Janino dependency version to fix thread safety issue… #19839
Conversation
… with Janino when compiling generated code.
I think we don't need this since we need to upgrade to the next janino release for the issue related to SPARK-18016. |
Which version? if it's unreleased, I don't see a harm in updating this now and later too. If it's released, we can just update it here. |
Test build #3997 has finished for PR 19839 at commit
|
You'll need to run |
No, it is unreleased. Yes, sure, we can also update it now and later too. |
Yea, we would like to use a version that includes this. However, it is not released yet. SGTM to use the latest released version after running a script. |
test this please |
Test build #84322 has finished for PR 19839 at commit
|
… with Janino when compiling generated code. ## What changes were proposed in this pull request? Bump up Janino dependency version to fix thread safety issue during compiling generated code ## How was this patch tested? Check https://issues.apache.org/jira/browse/SPARK-22373 for details. Converted part of the code in CodeGenerator into a standalone application, so the issue can be consistently reproduced locally. Verified that changing Janino dependency version resolved this issue. Author: Min Shen <mshen@linkedin.com> Closes #19839 from Victsm/SPARK-22373. (cherry picked from commit 7da1f57) Signed-off-by: Sean Owen <sowen@cloudera.com>
Merged to master/2.2/2.1 |
… with Janino when compiling generated code. ## What changes were proposed in this pull request? Bump up Janino dependency version to fix thread safety issue during compiling generated code ## How was this patch tested? Check https://issues.apache.org/jira/browse/SPARK-22373 for details. Converted part of the code in CodeGenerator into a standalone application, so the issue can be consistently reproduced locally. Verified that changing Janino dependency version resolved this issue. Author: Min Shen <mshen@linkedin.com> Closes #19839 from Victsm/SPARK-22373. (cherry picked from commit 7da1f57) Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen, seems this one causes a build failure for branch-2.1: https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-2.1-test-sbt-hadoop-2.2/641/console
Seems it's because |
Will actually open a PR shortly :). |
… with Janino when compiling generated code. ## What changes were proposed in this pull request? Bump up Janino dependency version to fix thread safety issue during compiling generated code ## How was this patch tested? Check https://issues.apache.org/jira/browse/SPARK-22373 for details. Converted part of the code in CodeGenerator into a standalone application, so the issue can be consistently reproduced locally. Verified that changing Janino dependency version resolved this issue. Author: Min Shen <mshen@linkedin.com> Closes apache#19839 from Victsm/SPARK-22373. (cherry picked from commit 7da1f57) Signed-off-by: Sean Owen <sowen@cloudera.com>
… with Janino when compiling generated code.
What changes were proposed in this pull request?
Bump up Janino dependency version to fix thread safety issue during compiling generated code
How was this patch tested?
Check https://issues.apache.org/jira/browse/SPARK-22373 for details.
Converted part of the code in CodeGenerator into a standalone application, so the issue can be consistently reproduced locally.
Verified that changing Janino dependency version resolved this issue.