[SPARK-22817][R] Use fixed testthat version for SparkR tests in AppVeyor #20003

HyukjinKwon · 2017-12-16T15:59:39Z

What changes were proposed in this pull request?

testthat 2.0.0 is released and AppVeyor now started to use it instead of 1.0.2. And then, we started to have R tests failed in AppVeyor. See - https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1967-master

Error in get(name, envir = asNamespace(pkg), inherits = FALSE) : 
  object 'run_tests' not found
Calls: ::: -> get

This seems because we rely on internal testthat:::run_tests here:

https://github.com/r-lib/testthat/blob/v1.0.2/R/test-package.R#L62-L75

spark/R/pkg/tests/run-all.R

Lines 49 to 52 in dc4c351

    
           testthat:::run_tests("SparkR", 
        
                                file.path(sparkRDir, "pkg", "tests", "fulltests"), 
        
                                NULL, 
        
                                "summary")

However, seems it was removed out from 2.0.0. I tried few other exposed APIs like test_dir but I failed to make a good compatible fix.

Seems we better fix the testthat version first to make the build passed.

How was this patch tested?

Manually tested and AppVeyor tests.

HyukjinKwon · 2017-12-16T16:01:27Z

Note that this is unrelated with the ongoing CRAN check failure in Jenkins. AppVeyor tests are being failed for a separate reason and we don't run CRAN check in AppVeyor.

HyukjinKwon · 2017-12-16T16:04:53Z

cc @felixcheung, could you take a look please?

SparkQA · 2017-12-16T19:26:19Z

Test build #85009 has finished for PR 20003 at commit 887cfe8.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2017-12-16T19:27:57Z

Test build #85010 has finished for PR 20003 at commit 0631168.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2017-12-17T05:34:40Z

I am going to merge this to resolve unrelated AppVeyor test failures in other PRs, and as CRAN check failure in Jenkins should not be related with it.

HyukjinKwon · 2017-12-17T05:38:28Z

I am also backporting this to branch-2.2 too. Currently, we don't run AppVeyor on those branches so it's fine but we will potentially meet this test failure if we start to run.

Also, I remember I manually run this before each release. It should be useful to backport.

## What changes were proposed in this pull request? `testthat` 2.0.0 is released and AppVeyor now started to use it instead of 1.0.2. And then, we started to have R tests failed in AppVeyor. See - https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1967-master ``` Error in get(name, envir = asNamespace(pkg), inherits = FALSE) : object 'run_tests' not found Calls: ::: -> get ``` This seems because we rely on internal `testthat:::run_tests` here: https://github.com/r-lib/testthat/blob/v1.0.2/R/test-package.R#L62-L75 https://github.com/apache/spark/blob/dc4c351837879dab26ad8fb471dc51c06832a9e4/R/pkg/tests/run-all.R#L49-L52 However, seems it was removed out from 2.0.0. I tried few other exposed APIs like `test_dir` but I failed to make a good compatible fix. Seems we better fix the `testthat` version first to make the build passed. ## How was this patch tested? Manually tested and AppVeyor tests. Author: hyukjinkwon <gurwls223@gmail.com> Closes #20003 from HyukjinKwon/SPARK-22817. (cherry picked from commit c2aeddf) Signed-off-by: hyukjinkwon <gurwls223@gmail.com>

HyukjinKwon · 2017-12-17T05:42:04Z

Merged to master and branch-2.2.

HyukjinKwon · 2018-03-24T03:09:00Z

@shaneknapp, the current failure of https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.6-ubuntu-test/509/console can be fixed by lowering the version of testthat just as a gentle remainder.

@felixcheung opened JIRA for it here - https://issues.apache.org/jira/plugins/servlet/mobile#issue/SPARK-23435

cc @JoshRosen, @shivaram and @falaki too just FYI in case.

felixcheung · 2018-03-24T06:58:38Z

yea, I started doing some work but was staled, let me check..

## What changes were proposed in this pull request? `testthat` 2.0.0 is released and AppVeyor now started to use it instead of 1.0.2. And then, we started to have R tests failed in AppVeyor. See - https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1967-master ``` Error in get(name, envir = asNamespace(pkg), inherits = FALSE) : object 'run_tests' not found Calls: ::: -> get ``` This seems because we rely on internal `testthat:::run_tests` here: https://github.com/r-lib/testthat/blob/v1.0.2/R/test-package.R#L62-L75 https://github.com/apache/spark/blob/dc4c351837879dab26ad8fb471dc51c06832a9e4/R/pkg/tests/run-all.R#L49-L52 However, seems it was removed out from 2.0.0. I tried few other exposed APIs like `test_dir` but I failed to make a good compatible fix. Seems we better fix the `testthat` version first to make the build passed. ## How was this patch tested? Manually tested and AppVeyor tests. Author: hyukjinkwon <gurwls223@gmail.com> Closes apache#20003 from HyukjinKwon/SPARK-22817. (cherry picked from commit c2aeddf) Signed-off-by: hyukjinkwon <gurwls223@gmail.com>

### What changes were proposed in this pull request? - Update `testthat` to >= 2.0.0 - Replace of `testthat:::run_tests` with `testthat:::test_package_dir` - Add trivial assertions for tests, without any expectations, to avoid skipping. - Update related docs. ### Why are the changes needed? `testthat` version has been frozen by [SPARK-22817](https://issues.apache.org/jira/browse/SPARK-22817) / #20003, but 1.0.2 is pretty old, and we shouldn't keep things in this state forever. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? - Existing CI pipeline: - Windows build on AppVeyor, R 3.6.2, testthtat 2.3.1 - Linux build on Jenkins, R 3.1.x, testthat 1.0.2 - Additional builds with thesthat 2.3.1 using [sparkr-build-sandbox](https://github.com/zero323/sparkr-build-sandbox) on c7ed64a R 3.4.4 (image digest ec9032f8cf98) ``` docker pull zero323/sparkr-build-sandbox:3.4.4 docker run zero323/sparkr-build-sandbox:3.4.4 zero323 --branch SPARK-23435 --commit c7ed64a --public-key https://keybase.io/zero323/pgp_keys.asc ``` 3.5.3 (image digest 0b1759ee4d1d) ``` docker pull zero323/sparkr-build-sandbox:3.5.3 docker run zero323/sparkr-build-sandbox:3.5.3 zero323 --branch SPARK-23435 --commit c7ed64a --public-key https://keybase.io/zero323/pgp_keys.asc ``` and 3.6.2 (image digest 6594c8ceb72f) ``` docker pull zero323/sparkr-build-sandbox:3.6.2 docker run zero323/sparkr-build-sandbox:3.6.2 zero323 --branch SPARK-23435 --commit c7ed64a --public-key https://keybase.io/zero323/pgp_keys.asc ```` Corresponding [asciicast](https://asciinema.org/) are available as 10.5281/zenodo.3629431 [![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.3629431.svg)](https://doi.org/10.5281/zenodo.3629431) (a bit to large to burden asciinema.org, but can run locally via `asciinema play`). ---------------------------- Continued from #27328 Closes #27359 from zero323/SPARK-23435. Authored-by: zero323 <mszymkiewicz@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>

- Update `testthat` to >= 2.0.0 - Replace of `testthat:::run_tests` with `testthat:::test_package_dir` - Add trivial assertions for tests, without any expectations, to avoid skipping. - Update related docs. `testthat` version has been frozen by [SPARK-22817](https://issues.apache.org/jira/browse/SPARK-22817) / apache#20003, but 1.0.2 is pretty old, and we shouldn't keep things in this state forever. No. - Existing CI pipeline: - Windows build on AppVeyor, R 3.6.2, testthtat 2.3.1 - Linux build on Jenkins, R 3.1.x, testthat 1.0.2 - Additional builds with thesthat 2.3.1 using [sparkr-build-sandbox](https://github.com/zero323/sparkr-build-sandbox) on c7ed64a R 3.4.4 (image digest ec9032f8cf98) ``` docker pull zero323/sparkr-build-sandbox:3.4.4 docker run zero323/sparkr-build-sandbox:3.4.4 zero323 --branch SPARK-23435 --commit c7ed64a --public-key https://keybase.io/zero323/pgp_keys.asc ``` 3.5.3 (image digest 0b1759ee4d1d) ``` docker pull zero323/sparkr-build-sandbox:3.5.3 docker run zero323/sparkr-build-sandbox:3.5.3 zero323 --branch SPARK-23435 --commit c7ed64a --public-key https://keybase.io/zero323/pgp_keys.asc ``` and 3.6.2 (image digest 6594c8ceb72f) ``` docker pull zero323/sparkr-build-sandbox:3.6.2 docker run zero323/sparkr-build-sandbox:3.6.2 zero323 --branch SPARK-23435 --commit c7ed64a --public-key https://keybase.io/zero323/pgp_keys.asc ```` Corresponding [asciicast](https://asciinema.org/) are available as 10.5281/zenodo.3629431 [![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.3629431.svg)](https://doi.org/10.5281/zenodo.3629431) (a bit to large to burden asciinema.org, but can run locally via `asciinema play`). ---------------------------- Continued from apache#27328 Closes apache#27359 from zero323/SPARK-23435. Authored-by: zero323 <mszymkiewicz@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>

### What changes were proposed in this pull request? This PR backports #27359: - Update `testthat` to >= 2.0.0 - Replace of `testthat:::run_tests` with `testthat:::test_package_dir` - Add trivial assertions for tests, without any expectations, to avoid skipping. - Update related docs. ### Why are the changes needed? `testthat` version has been frozen by [SPARK-22817](https://issues.apache.org/jira/browse/SPARK-22817) / #20003, but 1.0.2 is pretty old, and we shouldn't keep things in this state forever. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? - Existing CI pipeline: - Windows build on AppVeyor, R 3.6.2, testthtat 2.3.1 - Linux build on Jenkins, R 3.1.x, testthat 1.0.2 - Additional builds with thesthat 2.3.1 using [sparkr-build-sandbox](https://github.com/zero323/sparkr-build-sandbox) on c7ed64a R 3.4.4 (image digest ec9032f8cf98) ``` docker pull zero323/sparkr-build-sandbox:3.4.4 docker run zero323/sparkr-build-sandbox:3.4.4 zero323 --branch SPARK-23435 --commit c7ed64a --public-key https://keybase.io/zero323/pgp_keys.asc ``` 3.5.3 (image digest 0b1759ee4d1d) ``` docker pull zero323/sparkr-build-sandbox:3.5.3 docker run zero323/sparkr-build-sandbox:3.5.3 zero323 --branch SPARK-23435 --commit c7ed64a --public-key https://keybase.io/zero323/pgp_keys.asc ``` and 3.6.2 (image digest 6594c8ceb72f) ``` docker pull zero323/sparkr-build-sandbox:3.6.2 docker run zero323/sparkr-build-sandbox:3.6.2 zero323 --branch SPARK-23435 --commit c7ed64a --public-key https://keybase.io/zero323/pgp_keys.asc ```` Corresponding [asciicast](https://asciinema.org/) are available as 10.5281/zenodo.3629431 [![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.3629431.svg)](https://doi.org/10.5281/zenodo.3629431) (a bit to large to burden asciinema.org, but can run locally via `asciinema play`). ---------------------------- Continued from #27328 Closes #27379 from HyukjinKwon/testthat-2.0. Authored-by: zero323 <mszymkiewicz@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>

Use fixed testthat version for SparkR tests in AppVeyor

887cfe8

HyukjinKwon changed the title ~~[WIP][SPARK-22817][R] Use fixed testthat version for SparkR tests in AppVeyor~~ [SPARK-22817][R] Use fixed testthat version for SparkR tests in AppVeyor Dec 16, 2017

Fix comments

0631168

srowen approved these changes Dec 16, 2017

View reviewed changes

HyukjinKwon mentioned this pull request Dec 17, 2017

[SPARK-22465][Core] Add a safety-check to RDD defaultPartitioner #20002

Closed

asfgit closed this in c2aeddf Dec 17, 2017

HyukjinKwon mentioned this pull request Dec 17, 2017

[SPARK-22807] [Scheduler] Remove config that says docker and replace with container #19995

Closed

HyukjinKwon deleted the SPARK-22817 branch January 2, 2018 03:37

HyukjinKwon mentioned this pull request Jan 9, 2018

[SPARK-22063][R] Fixes lint check failures in R by latest commit sha1 ID of lint-r #19290

Closed

This was referenced Jan 22, 2020

[WIP][SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 #27328

Closed

[SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 #27359

Closed

HyukjinKwon mentioned this pull request Jan 29, 2020

[SPARK-23435][2.4][SPARKR][TESTS] Update testthat to >= 2.0.0 #27379

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SPARK-22817][R] Use fixed testthat version for SparkR tests in AppVeyor #20003

[SPARK-22817][R] Use fixed testthat version for SparkR tests in AppVeyor #20003

HyukjinKwon commented Dec 16, 2017

HyukjinKwon commented Dec 16, 2017

HyukjinKwon commented Dec 16, 2017

SparkQA commented Dec 16, 2017

SparkQA commented Dec 16, 2017

HyukjinKwon commented Dec 17, 2017

HyukjinKwon commented Dec 17, 2017 •

edited

Loading

HyukjinKwon commented Dec 17, 2017

HyukjinKwon commented Mar 24, 2018

felixcheung commented Mar 24, 2018

	testthat:::run_tests("SparkR",
	file.path(sparkRDir, "pkg", "tests", "fulltests"),
	NULL,
	"summary")

[SPARK-22817][R] Use fixed testthat version for SparkR tests in AppVeyor #20003

[SPARK-22817][R] Use fixed testthat version for SparkR tests in AppVeyor #20003

Conversation

HyukjinKwon commented Dec 16, 2017

What changes were proposed in this pull request?

How was this patch tested?

HyukjinKwon commented Dec 16, 2017

HyukjinKwon commented Dec 16, 2017

SparkQA commented Dec 16, 2017

SparkQA commented Dec 16, 2017

HyukjinKwon commented Dec 17, 2017

HyukjinKwon commented Dec 17, 2017 • edited Loading

HyukjinKwon commented Dec 17, 2017

HyukjinKwon commented Mar 24, 2018

felixcheung commented Mar 24, 2018

HyukjinKwon commented Dec 17, 2017 •

edited

Loading