Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-22862] Docs on lazy elimination of columns missing from an encoder #20048

Closed
wants to merge 1 commit into from
Closed

[SPARK-22862] Docs on lazy elimination of columns missing from an encoder #20048

wants to merge 1 commit into from
+4 −0

Conversation

marmbrus
Copy link
Contributor

This behavior has confused some users, so lets clarify it.

gatorsmile
gatorsmile approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Dec 21, 2017

Test build #85282 has finished for PR 20048 at commit 2f4e7b0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Dec 22, 2017
@marmbrus @gatorsmile
[SPARK-22862] Docs on lazy elimination of columns missing from an enc…
1cf3e3a 
…oder

This behavior has confused some users, so lets clarify it.

Author: Michael Armbrust <michael@databricks.com>

Closes #20048 from marmbrus/datasetAsDocs.

(cherry picked from commit 8df1da3)
Signed-off-by: gatorsmile <gatorsmile@gmail.com>
@gatorsmile
Copy link
Member

Thanks! Merged to master/2.2./2.1

asfgit pushed a commit that referenced this pull request Dec 22, 2017
@marmbrus @gatorsmile
[SPARK-22862] Docs on lazy elimination of columns missing from an enc…
1df8020 
…oder

This behavior has confused some users, so lets clarify it.

Author: Michael Armbrust <michael@databricks.com>

Closes #20048 from marmbrus/datasetAsDocs.

(cherry picked from commit 8df1da3)
Signed-off-by: gatorsmile <gatorsmile@gmail.com>
@asfgit asfgit closed this in 8df1da3 Dec 22, 2017
@zhangzg187 zhangzg187 mentioned this pull request Feb 8, 2018
Merged
MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
@marmbrus @MatthewRBruce
[SPARK-22862] Docs on lazy elimination of columns missing from an enc…
1c9d5c5 
…oder

This behavior has confused some users, so lets clarify it.

Author: Michael Armbrust <michael@databricks.com>

Closes apache#20048 from marmbrus/datasetAsDocs.

(cherry picked from commit 8df1da3)
Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatorsmile gatorsmile gatorsmile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marmbrus @SparkQA @gatorsmile