[SPARK-22905][ML][FollowUp] Fix GaussianMixtureModel save #20113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #85498 has finished for PR 20113 at commit
|
|
LGTM. Have you checked all the model.save ? |
|
@WeichenXu123 I use this cmd to list all impl of model.save, and others looks OK.
|
|
@zhengruifeng Good work! Thanks! |
|
LGTM |
bersprockets
pushed a commit
to bersprockets/spark
that referenced
this pull request
Aug 13, 2018
## What changes were proposed in this pull request? make sure model data is stored in order. WeichenXu123 ## How was this patch tested? existing tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closes apache#20113 from zhengruifeng/gmm_save.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
make sure model data is stored in order. @WeichenXu123
How was this patch tested?
existing tests