-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-22992][K8S] Remove assumption of the DNS domain #20187
Conversation
Test build #85805 has finished for PR 20187 at commit
|
Confirmed -- the FQDN is not going to work on clusters that have a custom cluster suffix. |
@foxish have you run the integration tests against this on both minikube and GKE? |
@liyinan926 -- not yet, will be running them shortly. |
Let me know how those tests go and then I'll merge this. |
All tests passed. @vanzin, this is ready to be merged. https://k8s-testgrid.appspot.com/sig-big-data#spark-periodic-default-gke |
Merging to master / 2.3. |
## What changes were proposed in this pull request? Remove the use of FQDN to access the driver because it assumes that it's set up in a DNS zone - `cluster.local` which is common but not ubiquitous Note that we already access the in-cluster API server through `kubernetes.default.svc`, so, by extension, this should work as well. The alternative is to introduce DNS zones for both of those addresses. ## How was this patch tested? Unit tests cc vanzin liyinan926 mridulm mccheah Author: foxish <ramanathana@google.com> Closes #20187 from foxish/cluster.local. (cherry picked from commit eed82a0) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
What changes were proposed in this pull request?
Remove the use of FQDN to access the driver because it assumes that it's set up in a DNS zone -
cluster.local
which is common but not ubiquitousNote that we already access the in-cluster API server through
kubernetes.default.svc
, so, by extension, this should work as well.The alternative is to introduce DNS zones for both of those addresses.
How was this patch tested?
Unit tests
cc @vanzin @liyinan926 @mridulm @mccheah