Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-23293][SQL] fix data source v2 self join #20466

Closed
wants to merge 1 commit into from
Closed

[SPARK-23293][SQL] fix data source v2 self join #20466

wants to merge 1 commit into from

Conversation

cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

DataSourceV2Relation should extend MultiInstanceRelation, to take care of self-join.

How was this patch tested?

a new test

@cloud-fan
Copy link
Contributor Author

cc @gatorsmile @rdblue @sameeragarwal

gatorsmile
gatorsmile reviewed Feb 1, 2018
View reviewed changes
Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Jenkins

@SparkQA
Copy link

SparkQA commented Feb 1, 2018

Test build #86912 has finished for PR 20466 at commit 6e55d10.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Feb 1, 2018

Test build #86927 has finished for PR 20466 at commit 6e55d10.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 1, 2018

Test build #86934 has finished for PR 20466 at commit 05253f0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jiangxb1987
jiangxb1987 approved these changes Feb 1, 2018
View reviewed changes
Copy link
Contributor

@jiangxb1987 jiangxb1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdblue
Copy link
Contributor

rdblue commented Feb 1, 2018

+1

Good to get this in before changes to the relation.

@gatorsmile
Copy link
Member

This is another bug fix of the new data source v2

Thanks! Merged to master/2.3

asfgit pushed a commit that referenced this pull request Feb 1, 2018
@cloud-fan @gatorsmile
[SPARK-23293][SQL] fix data source v2 self join
07a8f4d 
`DataSourceV2Relation` should extend `MultiInstanceRelation`, to take care of self-join.

a new test

Author: Wenchen Fan <wenchen@databricks.com>

Closes #20466 from cloud-fan/dsv2-selfjoin.

(cherry picked from commit 73da3b6)
Signed-off-by: gatorsmile <gatorsmile@gmail.com>
@asfgit asfgit closed this in 73da3b6 Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatorsmile gatorsmile gatorsmile left review comments

@jiangxb1987 jiangxb1987 jiangxb1987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cloud-fan @SparkQA @rdblue @gatorsmile @jiangxb1987