Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BackPort][SPARK-23490][SQL] Check storage.locationUri with existing table in CreateTable #20766

Closed

Conversation

gengliangwang
Copy link
Member

Backport #20660 to branch 2.3

What changes were proposed in this pull request?

For CreateTable with Append mode, we should check if storage.locationUri is the same with existing table in PreprocessTableCreation

In the current code, there is only a simple exception if the storage.locationUri is different with existing table:
org.apache.spark.sql.AnalysisException: Table or view not found:

which can be improved.

How was this patch tested?

Unit test

…reateTable

## What changes were proposed in this pull request?

For CreateTable with Append mode, we should check if `storage.locationUri` is the same with existing table in `PreprocessTableCreation`

In the current code, there is only a simple exception if the `storage.locationUri` is different with existing table:
`org.apache.spark.sql.AnalysisException: Table or view not found:`

which can be improved.

## How was this patch tested?

Unit test

Author: Wang Gengliang <gengliang.wang@databricks.com>

Closes apache#20660 from gengliangwang/locationUri.
@SparkQA
Copy link

SparkQA commented Mar 8, 2018

Test build #88068 has finished for PR 20766 at commit 597125f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gengliangwang
Copy link
Member Author

@gatorsmile

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asfgit pushed a commit that referenced this pull request Mar 8, 2018
…table in CreateTable

Backport #20660 to branch 2.3
=====================================
## What changes were proposed in this pull request?

For CreateTable with Append mode, we should check if `storage.locationUri` is the same with existing table in `PreprocessTableCreation`

In the current code, there is only a simple exception if the `storage.locationUri` is different with existing table:
`org.apache.spark.sql.AnalysisException: Table or view not found:`

which can be improved.

## How was this patch tested?

Unit test

Author: Wang Gengliang <gengliang.wang@databricks.com>

Closes #20766 from gengliangwang/backport_20660_to_2.3.
@gatorsmile
Copy link
Member

Thanks! Merged to 2.3.

Could you close it?

@gengliangwang gengliangwang deleted the backport_20660_to_2.3 branch March 9, 2018 03:09
peter-toth pushed a commit to peter-toth/spark that referenced this pull request Oct 6, 2018
…table in CreateTable

Backport apache#20660 to branch 2.3
=====================================
## What changes were proposed in this pull request?

For CreateTable with Append mode, we should check if `storage.locationUri` is the same with existing table in `PreprocessTableCreation`

In the current code, there is only a simple exception if the `storage.locationUri` is different with existing table:
`org.apache.spark.sql.AnalysisException: Table or view not found:`

which can be improved.

## How was this patch tested?

Unit test

Author: Wang Gengliang <gengliang.wang@databricks.com>

Closes apache#20766 from gengliangwang/backport_20660_to_2.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants