Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-24328][SQL] Fix scala.MatchError in literals.sql.out #20872

Closed
wants to merge 1 commit into from

Conversation

maropu
Copy link
Member

@maropu maropu commented Mar 21, 2018

What changes were proposed in this pull request?

To fix scala.MatchError in literals.sql.out, this pr added an entry for CalendarIntervalType in QueryExecution.toHiveStructString.

How was this patch tested?

Existing tests and added tests in literals.sql

@maropu
Copy link
Member Author

maropu commented Mar 21, 2018

@gatorsmile @cloud-fan

@SparkQA
Copy link

SparkQA commented Mar 21, 2018

Test build #88466 has finished for PR 20872 at commit 7bb29b2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master/2.3!

asfgit pushed a commit that referenced this pull request Mar 21, 2018
## What changes were proposed in this pull request?
To fix `scala.MatchError` in `literals.sql.out`, this pr added an entry for `CalendarIntervalType` in `QueryExecution.toHiveStructString`.

## How was this patch tested?
Existing tests and added tests in `literals.sql`

Author: Takeshi Yamamuro <yamamuro@apache.org>

Closes #20872 from maropu/FixIntervalTests.

(cherry picked from commit 98d0ea3)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
@asfgit asfgit closed this in 98d0ea3 Mar 21, 2018
@cloud-fan
Copy link
Contributor

actually this PR linked to a wrong JIRA, @maropu can you create a new jira and fix it? thanks!

@maropu
Copy link
Member Author

maropu commented May 16, 2018

@cloud-fan ok

@maropu maropu changed the title [SPARK-23264][SQL] Fix scala.MatchError in literals.sql.out [SPARK-24328][SQL] Fix scala.MatchError in literals.sql.out May 21, 2018
@maropu
Copy link
Member Author

maropu commented May 21, 2018

@cloud-fan Could you check and resolve the jira? Thanks! https://issues.apache.org/jira/browse/SPARK-24328

peter-toth pushed a commit to peter-toth/spark that referenced this pull request Oct 6, 2018
## What changes were proposed in this pull request?
To fix `scala.MatchError` in `literals.sql.out`, this pr added an entry for `CalendarIntervalType` in `QueryExecution.toHiveStructString`.

## How was this patch tested?
Existing tests and added tests in `literals.sql`

Author: Takeshi Yamamuro <yamamuro@apache.org>

Closes apache#20872 from maropu/FixIntervalTests.

(cherry picked from commit 98d0ea3)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants