Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-24526][build][test-maven] Spaces in the build dir causes failures in the build/mvn script #21534

Closed
wants to merge 1 commit into from

Conversation

trystanleftwich
Copy link

What changes were proposed in this pull request?

Fix the call to ${MVN_BIN} to be wrapped in quotes so it will handle having spaces in the path.

How was this patch tested?

Ran the following to confirm using the build/mvn tool with a space in the build dir now works without error

mkdir /tmp/test\ spaces
cd /tmp/test\ spaces
git clone https://github.com/apache/spark.git
cd spark
# Remove all mvn references in PATH so the script will download mvn to the local dir
./build/mvn -DskipTests clean package

Please review http://spark.apache.org/contributing.html before opening a pull request.

@HyukjinKwon
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Jun 12, 2018

Test build #91696 has finished for PR 21534 at commit bb12f3e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mgaido91
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Jun 12, 2018

Test build #91709 has finished for PR 21534 at commit bb12f3e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Jun 16, 2018

Test build #91975 has finished for PR 21534 at commit bb12f3e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon
Copy link
Member

@trystanleftwich, mind if I ask fix the title to [SPARK-24526][build][test-maven] Spaces in the build dir causes failures in the build/mvn script so that Jenkins triggers a build with Maven and then we can see if the build still passes for sure?

@trystanleftwich trystanleftwich changed the title [SPARK-24526][build] Spaces in the build dir causes failures in the build/mvn script [SPARK-24526][build][test-maven] Spaces in the build dir causes failures in the build/mvn script Jun 17, 2018
@trystanleftwich
Copy link
Author

@HyukjinKwon Updated the title per your request.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Jun 17, 2018

Test build #91998 has finished for PR 21534 at commit bb12f3e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Jun 17, 2018

Test build #92002 has finished for PR 21534 at commit bb12f3e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Jun 18, 2018

Test build #92009 has finished for PR 21534 at commit bb12f3e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master. It ran mvn correctly anyway.

@asfgit asfgit closed this in bce1775 Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants