-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-24526][build][test-maven] Spaces in the build dir causes failures in the build/mvn script #21534
Conversation
ok to test |
Test build #91696 has finished for PR 21534 at commit
|
retest this please |
Test build #91709 has finished for PR 21534 at commit
|
retest this please |
Test build #91975 has finished for PR 21534 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@trystanleftwich, mind if I ask fix the title to |
@HyukjinKwon Updated the title per your request. |
retest this please |
Test build #91998 has finished for PR 21534 at commit
|
retest this please |
Test build #92002 has finished for PR 21534 at commit
|
retest this please |
Test build #92009 has finished for PR 21534 at commit
|
Merged to master. It ran |
What changes were proposed in this pull request?
Fix the call to ${MVN_BIN} to be wrapped in quotes so it will handle having spaces in the path.
How was this patch tested?
Ran the following to confirm using the build/mvn tool with a space in the build dir now works without error
Please review http://spark.apache.org/contributing.html before opening a pull request.