Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Fix typo in serializer exception #21566

Closed

Conversation

rberenguel
Copy link
Contributor

What changes were proposed in this pull request?

Fix typo in exception raised in Python serializer

How was this patch tested?

No code changes

Please review http://spark.apache.org/contributing.html before opening a pull request.

@HyukjinKwon
Copy link
Member

@rberenguel, it's okay but mind taking another look around here and see if there are more typos while we are here? I am pretty sure there are more.

@rberenguel
Copy link
Contributor Author

@HyukjinKwon sure, no problem. I'm reading pieces of the source for a presentation on PySpark and this jumped quickly. I'll try to collect a few more 👍

@HyukjinKwon
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Jun 15, 2018

Test build #91878 has finished for PR 21566 at commit 370265f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@@ -461,7 +462,7 @@ def dumps(self, obj):
return obj


# Hook namedtuple, make it picklable
# Hack namedtuple, make it picklable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, haha. Hook and Hack.

@HyukjinKwon
Copy link
Member

Merged to master and branch-2.3.

asfgit pushed a commit that referenced this pull request Jun 15, 2018
## What changes were proposed in this pull request?

Fix typo in exception raised in Python serializer

## How was this patch tested?

No code changes

Please review http://spark.apache.org/contributing.html before opening a pull request.

Author: Ruben Berenguel Montoro <ruben@mostlymaths.net>

Closes #21566 from rberenguel/fix_typo_pyspark_serializers.

(cherry picked from commit 6567fc4)
Signed-off-by: hyukjinkwon <gurwls223@apache.org>
@asfgit asfgit closed this in 6567fc4 Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants