[SPARK-24529][Build][test-maven][follow-up] Add spotbugs 3.1.6 into maven build process #21994
Conversation
|
Test build #94177 has finished for PR 21994 at commit
|
|
retest this please |
|
cc @yhuai too |
|
Test build #94197 has finished for PR 21994 at commit
|
|
retest this please |
|
Test build #94210 has finished for PR 21994 at commit
|
| @@ -2609,6 +2609,28 @@ | |||
| </execution> | |||
| </executions> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>com.github.spotbugs</groupId> | |||
| <artifactId>spotbugs-maven-plugin</artifactId> | |||
There was a problem hiding this comment.
Actually, after having this plugin, I were unable to perform parallel builds.
https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3
There was a problem hiding this comment.
It sounds like this plug in is not thread safe.
There was a problem hiding this comment.
Oh, I have not tried this with parallel build. Spotbugs looks non MT-safe
There was a problem hiding this comment.
Adding spotbugs slows down my local build a lot. Can we hold this?
There was a problem hiding this comment.
Yea, this slows down 16ish mins and that was my concern at the very first place. Currently, it only affects Maven build though. +1 for holding on for now.
There was a problem hiding this comment.
let me check the elapsed time on my environment. +1 for holding on for now.
What changes were proposed in this pull request?
This PR tries to add spotbugs after upgrading mvn. This is because we met a problem with old mvn.
How was this patch tested?
existing UTs