Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove annotation @Experimental #22463

Closed
wants to merge 2 commits into from
Closed

Conversation

wanqulou
Copy link

@wanqulou wanqulou commented Sep 19, 2018

What changes were proposed in this pull request?

http://spark.apache.org/docs/latest/streaming-kafka-integration.html
spark-streaming-kafka-0-8 is deprecated and spark-streaming-kafka-0-10 is stable

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@HyukjinKwon
Copy link
Member

Why don't we just leave it or mark them as deprecated.

@markhamstra
Copy link
Contributor

Where is the discussion on these utility methods no longer being Experimental? I'm not saying that they are not stable, but the Kafka 0.10 API in general being considered to be stable doesn't preclude some Kafka-related methods from still being other than stable, and promoting API to stable (i.e. cannot be changed without a major release) is a pretty big deal.

@srowen
Copy link
Member

srowen commented Sep 24, 2018

Yeah, I think Experimental is over-used in the APIs. They just never get un-marked and lots of pretty old stuff, that de facto is just not changeable now, is still labeled this way. This seems to be more "DeveloperAPI" than "Experimental". Still, I also don't know the right answer for this code. Ping the author?

I figured we'd remove just about all current Experimental tags when, say, Spark 3 rolls around.

@srowen
Copy link
Member

srowen commented Nov 8, 2018

I'd close this, evaluate which Experimental tags look clearly 'wrong' (i.e. something long established in a public API) and then open a JIRA targeted at 3.0 to consider removing them.

@srowen srowen mentioned this pull request Nov 10, 2018
@asfgit asfgit closed this in a3ba3a8 Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants