[SPARK-28757][SQL] File table location should include both values of option path and paths
#25473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #109206 has finished for PR 25473 at commit
|
hvanhovell
reviewed
Aug 16, 2019
| @@ -43,11 +43,10 @@ trait FileDataSourceV2 extends TableProvider with DataSourceRegister { | |||
|
|
|||
| protected def getPaths(map: CaseInsensitiveStringMap): Seq[String] = { | |||
| val objectMapper = new ObjectMapper() | |||
| Option(map.get("paths")).map { pathStr => | |||
| val paths = Option(map.get("paths")).map { pathStr => | |||
There was a problem hiding this comment.
NIT: you can convert the option to a Seq, so you don't need to the getOrElse call.
There was a problem hiding this comment.
The result of .map { pathStr => objectMapper.readValue(pathStr, classOf[Array[String]]).toSeq is Option[Seq[String]]. I think the getOrElse is fine here.
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If both options
pathandpathsare passed to file data source v2, both values of the options should be included as the target paths.Why are the changes needed?
In V1 implementation, file table location includes both values of option
pathandpaths.In the refactoring of #24025, the value of option
pathis ignored if "paths" are specified. We should make it consistent with V1.Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test