[SPARK-28844][SQL] Fix typo in SQLConf FILE_COMRESSION_FACTOR #25538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@triplesheep Thanks for the fix. Could you create a jira ticket in https://issues.apache.org/jira/browse/SPARK and change the title as |
srowen
approved these changes
Aug 21, 2019
|
@gengliangwang Done and the issue is SPARK-28844. Thanks for reviewing :) |
triplesheep
changed the title
|
cc @srowen @triplesheep @dongjoon-hyun could someone allow me to start the jenkins test ? |
|
ok to test |
|
Sorry for being late, @triplesheep . |
dongjoon-hyun
changed the title
|
Since this typo was introduced since 2.3, cc @kiszk , too. |
dongjoon-hyun
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
+1, LGTM. (Pending Jenkins testing).
Thank you for your first contribution, @triplesheep .
|
Test build #109552 has finished for PR 25538 at commit
|
|
I tested this manually. Merged to |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 22, 2019
Fix minor typo in SQLConf. `FILE_COMRESSION_FACTOR` -> `FILE_COMPRESSION_FACTOR` Make conf more understandable. No. (`spark.sql.sources.fileCompressionFactor` is unchanged.) Pass the Jenkins with the existing tests. Closes #25538 from triplesheep/TYPO-FIX. Authored-by: triplesheep <triplesheep0419@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 48578a4) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 22, 2019
Fix minor typo in SQLConf. `FILE_COMRESSION_FACTOR` -> `FILE_COMPRESSION_FACTOR` Make conf more understandable. No. (`spark.sql.sources.fileCompressionFactor` is unchanged.) Pass the Jenkins with the existing tests. Closes #25538 from triplesheep/TYPO-FIX. Authored-by: triplesheep <triplesheep0419@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 48578a4) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
|
Hi, @triplesheep . What is your JIRA ID? |
rluta
pushed a commit
to rluta/spark
that referenced
this pull request
Sep 17, 2019
Fix minor typo in SQLConf. `FILE_COMRESSION_FACTOR` -> `FILE_COMPRESSION_FACTOR` Make conf more understandable. No. (`spark.sql.sources.fileCompressionFactor` is unchanged.) Pass the Jenkins with the existing tests. Closes apache#25538 from triplesheep/TYPO-FIX. Authored-by: triplesheep <triplesheep0419@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 48578a4) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Sep 26, 2019
Fix minor typo in SQLConf. `FILE_COMRESSION_FACTOR` -> `FILE_COMPRESSION_FACTOR` Make conf more understandable. No. (`spark.sql.sources.fileCompressionFactor` is unchanged.) Pass the Jenkins with the existing tests. Closes apache#25538 from triplesheep/TYPO-FIX. Authored-by: triplesheep <triplesheep0419@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 48578a4) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix minor typo in SQLConf.
FILE_COMRESSION_FACTOR->FILE_COMPRESSION_FACTORWhy are the changes needed?
Make conf more understandable.
Does this PR introduce any user-facing change?
No. (
spark.sql.sources.fileCompressionFactoris unchanged.)How was this patch tested?
Pass the Jenkins with the existing tests.