[SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol #25547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @zhengruifeng ! |
| @@ -313,7 +313,8 @@ class LinearSVCModel private[classification] ( | |||
| setDefault(threshold, 0.0) | |||
|
|
|||
| @Since("2.2.0") | |||
| def setWeightCol(value: Double): this.type = set(threshold, value) | |||
| @deprecated("This method is deprecated and will be removed in the future.", "2.4.4") | |||
There was a problem hiding this comment.
Since we already removed this, shall we use in 3.0.0 instead of in the future?
There was a problem hiding this comment.
I am not sure but 2.4.5 maybe anothor option?
There was a problem hiding this comment.
Nope. That's radical. We don't remove API in maintenance release. 3.0.0 is natural for this kind of removal. I mean the semantic version, major.minor.maintenance.
All releases with the same major version number will have API compatibility
|
cc @srowen |
dongjoon-hyun
changed the title
|
Test build #109549 has finished for PR 25547 at commit
|
dongjoon-hyun
requested changes
Aug 22, 2019
|
updated. Thanks for reviewing and explanation! @dongjoon-hyun |
|
Test build #109558 has finished for PR 25547 at commit
|
dongjoon-hyun
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
+1, LGTM. Merged to branch-2.4.
This PR already pass the Jenkins and the last commit is only string change at deprecation message.
Thank you for update, @zhengruifeng .
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 22, 2019
### What changes were proposed in this pull request? deprecate `LinearSVCModel.setWeightCol`, and make it a no-op ### Why are the changes needed? `LinearSVCModel` should not provide this setter, moreover, this method is wrongly defined. ### Does this PR introduce any user-facing change? no, this method is only deprecated ### How was this patch tested? existing suites Closes #25547 from zhengruifeng/svc_model_deprecate_setWeight_2.4. Authored-by: zhengruifeng <ruifengz@foxmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
rluta
pushed a commit
to rluta/spark
that referenced
this pull request
Sep 17, 2019
### What changes were proposed in this pull request? deprecate `LinearSVCModel.setWeightCol`, and make it a no-op ### Why are the changes needed? `LinearSVCModel` should not provide this setter, moreover, this method is wrongly defined. ### Does this PR introduce any user-facing change? no, this method is only deprecated ### How was this patch tested? existing suites Closes apache#25547 from zhengruifeng/svc_model_deprecate_setWeight_2.4. Authored-by: zhengruifeng <ruifengz@foxmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Sep 26, 2019
### What changes were proposed in this pull request? deprecate `LinearSVCModel.setWeightCol`, and make it a no-op ### Why are the changes needed? `LinearSVCModel` should not provide this setter, moreover, this method is wrongly defined. ### Does this PR introduce any user-facing change? no, this method is only deprecated ### How was this patch tested? existing suites Closes apache#25547 from zhengruifeng/svc_model_deprecate_setWeight_2.4. Authored-by: zhengruifeng <ruifengz@foxmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
deprecate
LinearSVCModel.setWeightCol, and make it a no-opWhy are the changes needed?
LinearSVCModelshould not provide this setter, moreover, this method is wrongly defined.Does this PR introduce any user-facing change?
no, this method is only deprecated
How was this patch tested?
existing suites