[SPARK-29529][DOCS]Remove unnecessary orc version and hive version in doc #26146
Conversation
|
ok to test |
|
Test build #112210 has finished for PR 26146 at commit
|
docs/sql-data-sources-orc.md
Outdated
| @@ -31,7 +31,7 @@ the vectorized reader is used when `spark.sql.hive.convertMetastoreOrc` is also | |||
| <tr> | |||
| <td><code>spark.sql.orc.impl</code></td> | |||
| <td><code>native</code></td> | |||
| <td>The name of ORC implementation. It can be one of <code>native</code> and <code>hive</code>. <code>native</code> means the native ORC support that is built on Apache ORC 1.4. `hive` means the ORC library in Hive 1.2.1.</td> | |||
| <td>The name of ORC implementation. It can be one of <code>native</code> and <code>hive</code>. <code>native</code> means the native ORC support that is built on Apache ORC 1.5. `hive` means the ORC library in Hive 1.2.1.</td> | |||
There was a problem hiding this comment.
Let's just remove versions from this statement entirely? it's not the right place
There was a problem hiding this comment.
Ur, BTW, it seems that we need to rewrite all. Oops. Late duplicated comment.Hive 1.2.1 also became wrong because Hadoop 3.2 profile means ORC 1.6, too.
cc @wangyum
|
Test build #112265 has finished for PR 26146 at commit
|
There was a problem hiding this comment.
@denglingang . Please file another JIRA for this and use it as the PR title prefix.
This seems not a follow-up of SPARK-24576 now.
denglingang
changed the title
|
Test build #112358 has finished for PR 26146 at commit
|
|
Test build #112425 has finished for PR 26146 at commit
|
|
I'm going to merge this. linter and build passed, and we don;t build the doc in PR builder. |
|
Merged to master. |
|
Test build #112427 has finished for PR 26146 at commit
|
|
Late LGTM. Thank you all. |
What changes were proposed in this pull request?
This PR remove unnecessary orc version and hive version in doc.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A.