[SPARK-30433][SQL] Make conflict attributes resolution more scalable in ResolveReferences #27105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan |
cloud-fan
reviewed
Jan 6, 2020
| } | ||
|
|
||
| /* | ||
| * Note that it's possible for conflictPlans to be empty while it implies that there |
There was a problem hiding this comment.
`conflictPlans` can be empty which implies that ...
cloud-fan
reviewed
Jan 6, 2020
| // transformDown so that we can replace all the old Relations in one turn due to | ||
| // the reason that conflictPlans are also collected in pre-order. | ||
| right transformDown { | ||
| case r if conflictPlanMap.contains(r) => conflictPlanMap(r) |
There was a problem hiding this comment.
nit: case r => conflictPlanMap.getOrElse(r, r)
|
Test build #116153 has finished for PR 27105 at commit
|
|
Test build #116168 has finished for PR 27105 at commit
|
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR tries to make conflict attributes resolution in
ResolveReferencesmore scalable by doing resolution in batch way.Why are the changes needed?
Currently,
ResolveReferencesrule only resolves conflict attributes of one single conflict plan pair in one iteration, which can be inefficient when there're many conflicts.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Covered by existed tests.