[SPARK-32406][SQL][FOLLOWUP] Make RESET fail against static and core configs #29297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gatorsmile @cloud-fan @dongjoon-hyun @maropu thanks very much. |
cloud-fan
approved these changes
Jul 30, 2020
|
Test build #126808 has started for PR 29297 at commit |
HyukjinKwon
approved these changes
Jul 31, 2020
|
Test build #126846 has finished for PR 29297 at commit
|
|
retest this please |
|
Test build #126868 has finished for PR 29297 at commit
|
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This followup addresses comments from #29202 (comment)
make RESET static SQL configs/spark core configs fail as same as the SET command. Not that, for core ones, they have to be pre-registered, otherwise, they are still able to be SET/RESET
add test cases for configurations w/ optional default values
Why are the changes needed?
behavior change with suggestions from PMCs
Does this PR introduce any user-facing change?
Yes, RESET will fail after this PR, before it just does nothing because the static ones are static.
How was this patch tested?
add more tests.