[SPARK-32832][SS] Use CaseInsensitiveMap for DataStreamReader/Writer options #29702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan and @HeartSaVioR |
cloud-fan
reviewed
Sep 10, 2020
| @@ -535,5 +536,5 @@ final class DataStreamReader private[sql](sparkSession: SparkSession) extends Lo | |||
|
|
|||
| private var userSpecifiedSchema: Option[StructType] = None | |||
|
|
|||
| private var extraOptions = new scala.collection.mutable.HashMap[String, String] | |||
| private var extraOptions = CaseInsensitiveMap[String](Map.empty) | |||
There was a problem hiding this comment.
DataStreamReader support reading DS v2, shall we get the original map at that place?
There was a problem hiding this comment.
Thanks. It's updated now.
|
Test build #128475 has finished for PR 29702 at commit
|
cloud-fan
approved these changes
Sep 10, 2020
|
Test build #128477 has finished for PR 29702 at commit
|
|
Thank you again, @cloud-fan . Merged to master/3.0. |
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 10, 2020
…options
This PR aims to fix indeterministic behavior on DataStreamReader/Writer options like the following.
```scala
scala> spark.readStream.format("parquet").option("paTh", "1").option("PATH", "2").option("Path", "3").option("patH", "4").option("path", "5").load()
org.apache.spark.sql.AnalysisException: Path does not exist: 1;
```
This will make the behavior deterministic.
Yes, but the previous behavior is indeterministic.
Pass the newly test cases.
Closes #29702 from dongjoon-hyun/SPARK-32832.
Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 2f85f95)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Test build #128483 has finished for PR 29702 at commit
|
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 11, 2020
…iter options ### What changes were proposed in this pull request? This is a backport of #29702 . This PR aims to fix indeterministic behavior on DataStreamReader/Writer options like the following. ```scala scala> spark.readStream.format("parquet").option("paTh", "1").option("PATH", "2").option("Path", "3").option("patH", "4").option("path", "5").load() org.apache.spark.sql.AnalysisException: Path does not exist: 1; ``` ### Why are the changes needed? This will make the behavior deterministic. ### Does this PR introduce _any_ user-facing change? Yes, but the previous behavior is indeterministic. ### How was this patch tested? Pass the newly test cases. Closes #29707 from dongjoon-hyun/SPARK-32832-2. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Oct 27, 2020
…options
This PR aims to fix indeterministic behavior on DataStreamReader/Writer options like the following.
```scala
scala> spark.readStream.format("parquet").option("paTh", "1").option("PATH", "2").option("Path", "3").option("patH", "4").option("path", "5").load()
org.apache.spark.sql.AnalysisException: Path does not exist: 1;
```
This will make the behavior deterministic.
Yes, but the previous behavior is indeterministic.
Pass the newly test cases.
Closes apache#29702 from dongjoon-hyun/SPARK-32832.
Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 2f85f95)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix indeterministic behavior on DataStreamReader/Writer options like the following.
Why are the changes needed?
This will make the behavior deterministic.
Does this PR introduce any user-facing change?
Yes, but the previous behavior is indeterministic.
How was this patch tested?
Pass the newly test cases.