[SPARK-32738][CORE][2.4] Should reduce the number of active threads if fatal error happens in Inbox.process
#29764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al error happens in `Inbox.process` ### What changes were proposed in this pull request? Processing for `ThreadSafeRpcEndpoint` is controlled by `numActiveThreads` in `Inbox`. Now if any fatal error happens during `Inbox.process`, `numActiveThreads` is not reduced. Then other threads can not process messages in that inbox, which causes the endpoint to "hang". For other type of endpoints, we also should keep `numActiveThreads` correct. This problem is more serious in previous Spark 2.x versions since the driver, executor and block manager endpoints are all thread safe endpoints. To fix this, we should reduce the number of active threads if fatal error happens in `Inbox.process`. ### Why are the changes needed? `numActiveThreads` is not correct when fatal error happens and will cause the described problem. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add a new test. Closes apache#29580 from wzhfy/deal_with_fatal_error. Authored-by: Zhenhua Wang <wzh_zju@163.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
wzhfy
commented
Sep 15, 2020
|
|
||
| val endpointRef = mock(classOf[NettyRpcEndpointRef]) | ||
| val dispatcher = mock(classOf[Dispatcher]) | ||
| val inbox = new Inbox(endpointRef, endpoint) |
There was a problem hiding this comment.
Here in 2.4 we pass an endpointRef as parameter instead of a name in 3.x
|
Test build #128723 has finished for PR 29764 at commit
|
|
retest this please |
|
Test build #128728 has finished for PR 29764 at commit
|
|
retest this please |
|
Test build #128791 has finished for PR 29764 at commit
|
|
retest this please |
|
Test build #128822 has finished for PR 29764 at commit
|
|
Finally all tests are passed... |
cloud-fan
approved these changes
Sep 18, 2020
mridulm
approved these changes
Sep 18, 2020
asfgit
pushed a commit
that referenced
this pull request
Sep 18, 2020
…f fatal error happens in `Inbox.process` This is a backport for [pr#29580](#29580) to branch 2.4. ### What changes were proposed in this pull request? Processing for `ThreadSafeRpcEndpoint` is controlled by `numActiveThreads` in `Inbox`. Now if any fatal error happens during `Inbox.process`, `numActiveThreads` is not reduced. Then other threads can not process messages in that inbox, which causes the endpoint to "hang". For other type of endpoints, we also should keep `numActiveThreads` correct. This problem is more serious in previous Spark 2.x versions since the driver, executor and block manager endpoints are all thread safe endpoints. To fix this, we should reduce the number of active threads if fatal error happens in `Inbox.process`. ### Why are the changes needed? `numActiveThreads` is not correct when fatal error happens and will cause the described problem. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add a new test. Closes #29764 from wzhfy/deal_with_fatal_error_2.4. Authored-by: Zhenhua Wang <wzh_zju@163.com> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
|
@wzhfy Can you close the PR please ? It has been merged to branch-2.4 |
|
@mridulm Closed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport for pr#29580 to branch 2.4.
What changes were proposed in this pull request?
Processing for
ThreadSafeRpcEndpointis controlled bynumActiveThreadsinInbox. Now if any fatal error happens duringInbox.process,numActiveThreadsis not reduced. Then other threads can not process messages in that inbox, which causes the endpoint to "hang". For other type of endpoints, we also should keepnumActiveThreadscorrect.This problem is more serious in previous Spark 2.x versions since the driver, executor and block manager endpoints are all thread safe endpoints.
To fix this, we should reduce the number of active threads if fatal error happens in
Inbox.process.Why are the changes needed?
numActiveThreadsis not correct when fatal error happens and will cause the described problem.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add a new test.