Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL][DOC][MINOR] Corrects input table names in the examples of CREATE FUNCTION doc #29920

Closed
wants to merge 1 commit into from

Conversation

iRakson
Copy link
Contributor

@iRakson iRakson commented Oct 1, 2020

What changes were proposed in this pull request?

Fix Typo

Why are the changes needed?

To maintain consistency.
Correct table name should be used for SELECT command.

Does this PR introduce any user-facing change?

Yes. Now CREATE FUNCTION doc will show the correct name of table.

How was this patch tested?

Manually. Doc changes.

@iRakson
Copy link
Contributor Author

iRakson commented Oct 1, 2020

@HyukjinKwon @srowen @dilipbiswal Please take a look. Thank You. 😊

@SparkQA
Copy link

SparkQA commented Oct 1, 2020

Test build #129305 has finished for PR 29920 at commit 9b888ef.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 1, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33920/

Copy link
Member

@maropu maropu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I checked it by myself and it looks okay.

@maropu maropu changed the title [MINOR][DOC][SQL] Fix typo in CREATE FUNCTION doc [SQL][DOC][MINOR] Corrects input table names in the examples of CREATE FUNCTION doc Oct 1, 2020
@maropu maropu closed this in d3dbe1a Oct 1, 2020
maropu pushed a commit that referenced this pull request Oct 1, 2020
…E FUNCTION doc

### What changes were proposed in this pull request?
Fix Typo

### Why are the changes needed?
To maintain consistency.
Correct table name should be used for SELECT command.

### Does this PR introduce _any_ user-facing change?
Yes. Now CREATE FUNCTION doc will show the correct name of table.

### How was this patch tested?
Manually. Doc changes.

Closes #29920 from iRakson/fixTypo.

Authored-by: iRakson <raksonrakesh@gmail.com>
Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
(cherry picked from commit d3dbe1a)
Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
@maropu
Copy link
Member

maropu commented Oct 1, 2020

Thanks, all! Merged to master/3.0.

@SparkQA
Copy link

SparkQA commented Oct 1, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33920/

@iRakson
Copy link
Contributor Author

iRakson commented Oct 1, 2020

Thanks everyone.

holdenk pushed a commit to holdenk/spark that referenced this pull request Oct 27, 2020
…E FUNCTION doc

### What changes were proposed in this pull request?
Fix Typo

### Why are the changes needed?
To maintain consistency.
Correct table name should be used for SELECT command.

### Does this PR introduce _any_ user-facing change?
Yes. Now CREATE FUNCTION doc will show the correct name of table.

### How was this patch tested?
Manually. Doc changes.

Closes apache#29920 from iRakson/fixTypo.

Authored-by: iRakson <raksonrakesh@gmail.com>
Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
(cherry picked from commit d3dbe1a)
Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants