-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL][DOC][MINOR] Corrects input table names in the examples of CREATE FUNCTION doc #29920
Conversation
@HyukjinKwon @srowen @dilipbiswal Please take a look. Thank You. 😊 |
Test build #129305 has finished for PR 29920 at commit
|
Kubernetes integration test starting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. I checked it by myself and it looks okay.
…E FUNCTION doc ### What changes were proposed in this pull request? Fix Typo ### Why are the changes needed? To maintain consistency. Correct table name should be used for SELECT command. ### Does this PR introduce _any_ user-facing change? Yes. Now CREATE FUNCTION doc will show the correct name of table. ### How was this patch tested? Manually. Doc changes. Closes #29920 from iRakson/fixTypo. Authored-by: iRakson <raksonrakesh@gmail.com> Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org> (cherry picked from commit d3dbe1a) Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
Thanks, all! Merged to master/3.0. |
Kubernetes integration test status success |
Thanks everyone. |
…E FUNCTION doc ### What changes were proposed in this pull request? Fix Typo ### Why are the changes needed? To maintain consistency. Correct table name should be used for SELECT command. ### Does this PR introduce _any_ user-facing change? Yes. Now CREATE FUNCTION doc will show the correct name of table. ### How was this patch tested? Manually. Doc changes. Closes apache#29920 from iRakson/fixTypo. Authored-by: iRakson <raksonrakesh@gmail.com> Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org> (cherry picked from commit d3dbe1a) Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
What changes were proposed in this pull request?
Fix Typo
Why are the changes needed?
To maintain consistency.
Correct table name should be used for SELECT command.
Does this PR introduce any user-facing change?
Yes. Now CREATE FUNCTION doc will show the correct name of table.
How was this patch tested?
Manually. Doc changes.