-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-33051][INFRA][R] Uses setup-r to install R in GitHub Actions build #29931
Conversation
cc @dongjoon-hyun. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM (Pending GitHub Action).
Merging it in. Relevant build passed (https://github.com/apache/spark/pull/29931/checks?check_run_id=1197148759 and https://github.com/apache/spark/pull/29931/checks?check_run_id=1197148479). |
Merged to master, branch-3.0 and branch-2.4. |
…uild ### What changes were proposed in this pull request? At SPARK-32493, the R installation was switched to manual installation because setup-r was broken. This seems fixed in the upstream so we should better switch it back. ### Why are the changes needed? To avoid maintaining the installation steps by ourselve. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? GitHub Actions build in this PR should test it. Closes #29931 from HyukjinKwon/recover-r-build. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit b205be5) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
…uild ### What changes were proposed in this pull request? At SPARK-32493, the R installation was switched to manual installation because setup-r was broken. This seems fixed in the upstream so we should better switch it back. ### Why are the changes needed? To avoid maintaining the installation steps by ourselve. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? GitHub Actions build in this PR should test it. Closes #29931 from HyukjinKwon/recover-r-build. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit b205be5) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Kubernetes integration test starting |
Kubernetes integration test status success |
Test build #129333 has finished for PR 29931 at commit
|
…uild ### What changes were proposed in this pull request? At SPARK-32493, the R installation was switched to manual installation because setup-r was broken. This seems fixed in the upstream so we should better switch it back. ### Why are the changes needed? To avoid maintaining the installation steps by ourselve. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? GitHub Actions build in this PR should test it. Closes apache#29931 from HyukjinKwon/recover-r-build. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit b205be5) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
What changes were proposed in this pull request?
At SPARK-32493, the R installation was switched to manual installation because setup-r was broken. This seems fixed in the upstream so we should better switch it back.
Why are the changes needed?
To avoid maintaining the installation steps by ourselve.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
GitHub Actions build in this PR should test it.