[MINOR][DOCS][EXAMPLE] Fix the Python manual_load_options_csv example #30082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
HyukjinKwon
approved these changes
Oct 18, 2020
|
Merged to master, branch-3.0 and branch-2.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Oct 18, 2020
### What changes were proposed in this pull request? This pull request changes the `sep` parameter's value from `:` to `;` in the example of `examples/src/main/python/sql/datasource.py`. This code snippet is shown on the Spark SQL Guide documentation. The `sep` parameter's value should be `;` since the data in https://github.com/apache/spark/blob/master/examples/src/main/resources/people.csv is separated by `;`. ### Why are the changes needed? To fix the example code so that it can be executed properly. ### Does this PR introduce _any_ user-facing change? Yes. This code snippet is shown on the Spark SQL Guide documentation: https://spark.apache.org/docs/latest/sql-data-sources-load-save-functions.html#manually-specifying-options ### How was this patch tested? By building the documentation and checking the Spark SQL Guide documentation manually in the local environment. Closes #30082 from kjmrknsn/fix-example-python-datasource. Authored-by: Keiji Yoshida <kjmrknsn@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
HyukjinKwon
pushed a commit
that referenced
this pull request
Oct 18, 2020
### What changes were proposed in this pull request? This pull request changes the `sep` parameter's value from `:` to `;` in the example of `examples/src/main/python/sql/datasource.py`. This code snippet is shown on the Spark SQL Guide documentation. The `sep` parameter's value should be `;` since the data in https://github.com/apache/spark/blob/master/examples/src/main/resources/people.csv is separated by `;`. ### Why are the changes needed? To fix the example code so that it can be executed properly. ### Does this PR introduce _any_ user-facing change? Yes. This code snippet is shown on the Spark SQL Guide documentation: https://spark.apache.org/docs/latest/sql-data-sources-load-save-functions.html#manually-specifying-options ### How was this patch tested? By building the documentation and checking the Spark SQL Guide documentation manually in the local environment. Closes #30082 from kjmrknsn/fix-example-python-datasource. Authored-by: Keiji Yoshida <kjmrknsn@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Oct 27, 2020
### What changes were proposed in this pull request? This pull request changes the `sep` parameter's value from `:` to `;` in the example of `examples/src/main/python/sql/datasource.py`. This code snippet is shown on the Spark SQL Guide documentation. The `sep` parameter's value should be `;` since the data in https://github.com/apache/spark/blob/master/examples/src/main/resources/people.csv is separated by `;`. ### Why are the changes needed? To fix the example code so that it can be executed properly. ### Does this PR introduce _any_ user-facing change? Yes. This code snippet is shown on the Spark SQL Guide documentation: https://spark.apache.org/docs/latest/sql-data-sources-load-save-functions.html#manually-specifying-options ### How was this patch tested? By building the documentation and checking the Spark SQL Guide documentation manually in the local environment. Closes apache#30082 from kjmrknsn/fix-example-python-datasource. Authored-by: Keiji Yoshida <kjmrknsn@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request changes the
sepparameter's value from:to;in the example ofexamples/src/main/python/sql/datasource.py. This code snippet is shown on the Spark SQL Guide documentation. Thesepparameter's value should be;since the data in https://github.com/apache/spark/blob/master/examples/src/main/resources/people.csv is separated by;.Why are the changes needed?
To fix the example code so that it can be executed properly.
Does this PR introduce any user-facing change?
Yes.
This code snippet is shown on the Spark SQL Guide documentation: https://spark.apache.org/docs/latest/sql-data-sources-load-save-functions.html#manually-specifying-options
How was this patch tested?
By building the documentation and checking the Spark SQL Guide documentation manually in the local environment.