[SPARK-33636][PYTHON][ML][3.0] Add labelsArray to PySpark StringIndexer #30580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @srowen |
|
cc @HyukjinKwon too. |
HyukjinKwon
reviewed
Dec 3, 2020
|
LGTM but I will leave it to @srowen. |
|
Test build #132080 has finished for PR 30580 at commit
|
|
Kubernetes integration test starting |
dongjoon-hyun
approved these changes
Dec 3, 2020
|
Kubernetes integration test status success |
HyukjinKwon
approved these changes
Dec 3, 2020
|
Thanks. Then I will merge this to branch-3.0. |
viirya
added a commit
that referenced
this pull request
Dec 3, 2020
### What changes were proposed in this pull request? This is a followup to add missing `labelsArray` to PySpark `StringIndexer`. ### Why are the changes needed? `labelsArray` is for multi-column case for `StringIndexer`. We should provide this accessor at PySpark side too. ### Does this PR introduce _any_ user-facing change? Yes, `labelsArray` was missing in PySpark `StringIndexer` in Spark 3.0. ### How was this patch tested? Unit test. Closes #30580 from viirya/SPARK-33636. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup to add missing
labelsArrayto PySparkStringIndexer.Why are the changes needed?
labelsArrayis for multi-column case forStringIndexer. We should provide this accessor at PySpark side too.Does this PR introduce any user-facing change?
Yes,
labelsArraywas missing in PySparkStringIndexerin Spark 3.0.How was this patch tested?
Unit test.