Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][INFRA] Add -Pdocker-integration-tests to GitHub Action Scala 2.13 build job #30661

Closed
wants to merge 1 commit into from
Closed

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Dec 8, 2020

What changes were proposed in this pull request?

This aims to add -Pdocker-integration-tests at GitHub Action job for Scala 2.13 compilation.

Why are the changes needed?

We fixed Scala 2.13 compilation of this module at #30660 . This PR will prevent accidental regression at that module.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GitHub Action Scala 2.13 job.

@sarutak
Copy link
Member

sarutak commented Dec 8, 2020

@dongjoon-hyun Thanks for the work! I planed to do this work after #30660 merged and verifying all docker-integration-tests pass.

@dongjoon-hyun
Copy link
Member Author

Oh, I see. Thanks, @sarutak .

@SparkQA
Copy link

SparkQA commented Dec 8, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37004/

@SparkQA
Copy link

SparkQA commented Dec 8, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37004/

@github-actions github-actions bot added the INFRA label Dec 8, 2020
@asfgit asfgit closed this in 3a6546d Dec 8, 2020
@sarutak
Copy link
Member

sarutak commented Dec 8, 2020

Scala 2.13 build pass on GitHub Actions. Merged to master and branch-3.1.
Thanks @dongjoon-hyun !

asfgit pushed a commit that referenced this pull request Dec 8, 2020
…2.13 build job

### What changes were proposed in this pull request?

This aims to add `-Pdocker-integration-tests` at GitHub Action job for Scala 2.13 compilation.

### Why are the changes needed?

We fixed Scala 2.13 compilation of this module at #30660 . This PR will prevent accidental regression at that module.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GitHub Action Scala 2.13 job.

Closes #30661 from dongjoon-hyun/SPARK-DOCKER-IT.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Kousuke Saruta <sarutak@oss.nttdata.com>
(cherry picked from commit 3a6546d)
Signed-off-by: Kousuke Saruta <sarutak@oss.nttdata.com>
@dongjoon-hyun
Copy link
Member Author

Thanks!

@SparkQA
Copy link

SparkQA commented Dec 8, 2020

Test build #132404 has finished for PR 30661 at commit 36c5ebf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Nice, LGTM!

@dongjoon-hyun dongjoon-hyun deleted the SPARK-DOCKER-IT branch December 8, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants