Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-33931][INFRA][3.0] Recover GitHub Action build_and_test job #30986

Closed
wants to merge 2 commits into from
Closed

[SPARK-33931][INFRA][3.0] Recover GitHub Action build_and_test job #30986

wants to merge 2 commits into from

Conversation

dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This is a backport of #30959 .
This PR aims to recover GitHub Action build_and_test job.

Why are the changes needed?

Currently, build_and_test job fails to start because of the following in master/branch-3.1 at least.

r-lib/actions/setup-r@v1 is not allowed to be used in apache/spark.
Actions in this workflow must be: created by GitHub, verified in the GitHub Marketplace,
within a repository owned by apache or match the following:
adoptopenjdk/*, apache/*, gradle/wrapper-validation-action.

Screen Shot 2020-12-28 at 10 06 11 PM

Does this PR introduce any user-facing change?

No. This is a test infra.

How was this patch tested?

To check GitHub Action build_and_test job on this PR.

@SparkQA
Copy link

SparkQA commented Dec 31, 2020

Test build #133576 has finished for PR 30986 at commit d7dd9fc.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 31, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38165/

@SparkQA
Copy link

SparkQA commented Jan 1, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38165/

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dongjoon-hyun added a commit that referenced this pull request Jan 1, 2021
### What changes were proposed in this pull request?

This is a backport of #30959 .
This PR aims to recover GitHub Action `build_and_test` job.

### Why are the changes needed?

Currently, `build_and_test` job fails to start because of  the following in master/branch-3.1 at least.
```
r-lib/actions/setup-rv1 is not allowed to be used in apache/spark.
Actions in this workflow must be: created by GitHub, verified in the GitHub Marketplace,
within a repository owned by apache or match the following:
adoptopenjdk/*, apache/*, gradle/wrapper-validation-action.
```
- https://github.com/apache/spark/actions/runs/449826457

![Screen Shot 2020-12-28 at 10 06 11 PM](https://user-images.githubusercontent.com/9700541/103262174-f1f13a80-4958-11eb-8ceb-631527155775.png)

### Does this PR introduce _any_ user-facing change?

No. This is a test infra.

### How was this patch tested?

To check GitHub Action `build_and_test` job on this PR.

Closes #30986 from dongjoon-hyun/SPARK-33931-3.0.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun
Copy link
Member Author

Thank you. Merged to branch-3.0.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-33931-3.0 branch January 1, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants