[SPARK-32691][3.0] Bump commons-crypto to v1.1.0 #31078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
+1, LGTM. Thank you for backporting, @huangtianhua .
In fact, I have been waiting for this. :)
|
Can one of the admins verify this patch? |
dongjoon-hyun
requested changes
Jan 7, 2021
|
Gentle ping, @huangtianhua . |
|
@dongjoon-hyun , thanks and will propose a new one :) |
The package commons-crypto-1.0.0 doesn't support aarch64 platform, change to use v1.1.0.
huangtianhua
force-pushed
the
origin/branch-3.0
branch
from
7455389
to
e333f99
Compare
dongjoon-hyun
approved these changes
Jan 12, 2021
There was a problem hiding this comment.
+1, LGTM. Thank you for updating, @huangtianhua .
Merged to branch-3.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 12, 2021
The package commons-crypto-1.0.0 doesn't support aarch64 platform, change to use v1.1.0. ### What changes were proposed in this pull request? Update the package commons-crypto to v1.1.0 to support aarch64 platform - https://issues.apache.org/jira/browse/CRYPTO-139 NOTE: This backport comes from #30275 ### Why are the changes needed? The package commons-crypto-1.0.0 available in the Maven repository doesn't support aarch64 platform. It costs long time in CryptoRandomFactory.getCryptoRandom(properties).nextBytes(iv) when NettyBlockRpcSever receive block data from client, if the time more than the default value 120s, IOException raised and client will retry replicate the block data to other executors. But in fact the replication is complete, it makes the replication number incorrect. This makes DistributedSuite tests pass. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes #31078 from huangtianhua/origin/branch-3.0. Authored-by: huangtianhua <huangtianhua223@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package commons-crypto-1.0.0 doesn't support
aarch64 platform, change to use v1.1.0.
What changes were proposed in this pull request?
Update the package commons-crypto to v1.1.0 to support aarch64 platform
NOTE: This backport comes from #30275
Why are the changes needed?
The package commons-crypto-1.0.0 available in the Maven repository
doesn't support aarch64 platform. It costs long time in
CryptoRandomFactory.getCryptoRandom(properties).nextBytes(iv) when NettyBlockRpcSever
receive block data from client, if the time more than the default value 120s, IOException raised and client
will retry replicate the block data to other executors. But in fact the replication is complete,
it makes the replication number incorrect.
This makes DistributedSuite tests pass.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.