-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-34151][SQL] Replaces java.io.File.toURL
with java.io.File.toURI.toURL
#31230
Conversation
Kubernetes integration test starting |
Kubernetes integration test status success |
Test build #134190 has finished for PR 31230 at commit
|
Are they all instances to fix @LuciferYang? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
@HyukjinKwon Let me check it again |
spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala Lines 1358 to 1372 in 78893b8
@HyukjinKwon The rest is as above. I don't know if this part of code is still useful. EDIT: seems
Yes |
Merged to master and branch-3.1. |
Thanks @LuciferYang. |
…oURI.toURL` ### What changes were proposed in this pull request? `java.io.FIle.toURL` method does not automatically escape characters that are illegal in URLs. Java doc recommended that new code convert an abstract pathname into a URL by first converting it into a URI, via the `toURI` method, and then converting the URI into a URL via the `URI.toURL` method. So this pr cleaned up the relevant cases in Spark code. ### Why are the changes needed? Cleaning up `Deprecated` Java API usage. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass the Jenkins or GitHub Action Closes #31230 from LuciferYang/SPARK-34151. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 163afa6) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
thx @HyukjinKwon ~ |
…oURI.toURL` ### What changes were proposed in this pull request? `java.io.FIle.toURL` method does not automatically escape characters that are illegal in URLs. Java doc recommended that new code convert an abstract pathname into a URL by first converting it into a URI, via the `toURI` method, and then converting the URI into a URL via the `URI.toURL` method. So this pr cleaned up the relevant cases in Spark code. ### Why are the changes needed? Cleaning up `Deprecated` Java API usage. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass the Jenkins or GitHub Action Closes apache#31230 from LuciferYang/SPARK-34151. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
What changes were proposed in this pull request?
java.io.FIle.toURL
method does not automatically escape characters that are illegal in URLs.Java doc recommended that new code convert an abstract pathname into a URL by first converting it into a URI, via the
toURI
method, and then converting the URI into a URL via theURI.toURL
method.So this pr cleaned up the relevant cases in Spark code.
Why are the changes needed?
Cleaning up
@Deprecated
Java API usage.Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the Jenkins or GitHub Action