-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId #31755
Conversation
To support +8:00 in Spark3 when execute sql `select to_utc_timestamp("2020-02-07 16:00:00", "GMT+8:00")` +8:00 this format is supported in PostgreSQL,hive, presto, but not supported in Spark3 https://issues.apache.org/jira/browse/SPARK-34392 no unit test Closes apache#31624 from Karl-WangSK/zone. Lead-authored-by: ShiKai Wang <wskqing@gmail.com> Co-authored-by: Karl-WangSK <shikai.wang@linkflowtech.com> Signed-off-by: Sean Owen <srowen@gmail.com>
cc: @srowen |
Kubernetes integration test starting |
Kubernetes integration test status success |
Test build #135799 has finished for PR 31755 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…tZoneId ### What changes were proposed in this pull request? To support +8:00 in Spark3 when execute sql `select to_utc_timestamp("2020-02-07 16:00:00", "GMT+8:00")` This is the backport of #31624 and the original author is Karl-WangSK . ### Why are the changes needed? +8:00 this format is supported in PostgreSQL,hive, presto, but not supported in Spark3 https://issues.apache.org/jira/browse/SPARK-34392 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? unit test Closes #31755 from maropu/SPARK-34392-BRANCH3.0. Authored-by: ShiKai Wang <wskqing@gmail.com> Signed-off-by: Sean Owen <srowen@gmail.com>
LOL I just tried to merge this as well. Hope it worked. |
Oh. :) |
I was late. Thanks. :) |
What changes were proposed in this pull request?
To support +8:00 in Spark3 when execute sql
select to_utc_timestamp("2020-02-07 16:00:00", "GMT+8:00")
This is the backport of #31624 and the original author is @Karl-WangSK .
Why are the changes needed?
+8:00 this format is supported in PostgreSQL,hive, presto, but not supported in Spark3
https://issues.apache.org/jira/browse/SPARK-34392
Does this PR introduce any user-facing change?
no
How was this patch tested?
unit test