Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35071][PYTHON] Rename Koalas to pandas-on-Spark in main codes #32166

Closed
wants to merge 2 commits into from

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Apr 14, 2021

What changes were proposed in this pull request?

This PR proposes to rename Koalas to pandas-on-Spark in main codes

Why are the changes needed?

To have the correct name in PySpark. NOTE that the official name in the main documentation will be pandas APIs on Spark to be extra clear. pandas-on-Spark is not the official term.

Does this PR introduce any user-facing change?

No, it's master-only change. It changes the docstring and class names.

How was this patch tested?

Manually tested via:

./python/run-tests --python-executable=python3 --modules pyspark-pandas

@HyukjinKwon
Copy link
Member Author

cc @ueshin @xinrong-databricks @itholic

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Test build #137344 has finished for PR 32166 at commit 4ca5c6d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class PandasOnSparkFrameMethods(object):
  • class PandasOnSparkSeriesMethods(object):
  • class PandasOnSparkPlotAccessor(PandasObject):
  • class PandasOnSparkBarPlot(PandasBarPlot, TopNPlotBase):
  • class PandasOnSparkBoxPlot(PandasBoxPlot, BoxPlotBase):
  • class PandasOnSparkHistPlot(PandasHistPlot, HistogramPlotBase):
  • class PandasOnSparkPiePlot(PandasPiePlot, TopNPlotBase):
  • class PandasOnSparkAreaPlot(PandasAreaPlot, SampledPlotBase):
  • class PandasOnSparkLinePlot(PandasLinePlot, SampledPlotBase):
  • class PandasOnSparkBarhPlot(PandasBarhPlot, TopNPlotBase):
  • class PandasOnSparkScatterPlot(PandasScatterPlot, TopNPlotBase):
  • class PandasOnSparkKdePlot(PandasKdePlot, KdePlotBase):
  • class PandasOnSparkUsageLogger(object):

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41923/

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41923/

@xinrong-meng
Copy link
Member

LGTM, thanks!

May I confirm that the official name in the main documentation will be PySpark APIs on Spark(according to the PR description) rather than Pandas APIs on Spark?

@github-actions
Copy link

Test build #748086638 for PR 32166 at commit 4ca5c6d.

@itholic
Copy link
Contributor

itholic commented Apr 15, 2021

@xinrong-databricks I think Pandas APIs on Spark is correct. Maybe it's typo.

Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon
Copy link
Member Author

Oops, I wonder how I missed so many instances ...

@github-actions
Copy link

Test build #750424771 for PR 32166 at commit c174c6f.

Copy link
Member

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SparkQA
Copy link

SparkQA commented Apr 15, 2021

Test build #137388 has finished for PR 32166 at commit c174c6f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 15, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41965/

@SparkQA
Copy link

SparkQA commented Apr 15, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41965/

@HyukjinKwon
Copy link
Member Author

Merged to master.

@HyukjinKwon HyukjinKwon deleted the rename-koalas branch January 4, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants