Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-37050][PYTHON] Update Conda installation instructions #34315

Closed
wants to merge 5 commits into from

Conversation

h-vetinari
Copy link
Contributor

@h-vetinari h-vetinari commented Oct 18, 2021

What changes were proposed in this pull request?

Improve conda installation docs

Why are the changes needed?

As requested here. Ideally, this should be backported to the 3.2-branch (so it becomes visible for the 3.2.0 installation documentation here).
CC @gengliangwang

Does this PR introduce any user-facing change?

No

How was this patch tested?

Not tested

@gengliangwang
Copy link
Member

@h-vetinari Thanks for the first contribution! Could you file a Jira ticket on https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=256 and follow the PR template?


### What changes were proposed in this pull request?


### Why are the changes needed?



### Does this PR introduce _any_ user-facing change?


### How was this patch tested?


@gengliangwang
Copy link
Member

gengliangwang commented Oct 18, 2021

@h-vetinari h-vetinari changed the title update conda installation instructions [SPARK-37050][Python] update conda installation instructions Oct 18, 2021
@HyukjinKwon HyukjinKwon changed the title [SPARK-37050][Python] update conda installation instructions [SPARK-37050][PYTHON] Update Conda installation instructions Oct 19, 2021
@HyukjinKwon
Copy link
Member

ok to test

@SparkQA

This comment has been minimized.

@SparkQA

This comment has been minimized.

@HyukjinKwon
Copy link
Member

@srowen, when you find some time, can you help reviewing this please 🙏

@SparkQA

This comment has been minimized.

@SparkQA

This comment has been minimized.

@SparkQA

This comment has been minimized.

@SparkQA

This comment has been minimized.

@SparkQA

This comment has been minimized.

@SparkQA

This comment has been minimized.

@SparkQA

This comment has been minimized.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good otherwise - made some minor suggestions. Thanks for your PR @h-vetinari.

python/docs/source/getting_started/install.rst Outdated Show resolved Hide resolved
python/docs/source/getting_started/install.rst Outdated Show resolved Hide resolved
@HyukjinKwon
Copy link
Member

Jenkins, ok to test

@SparkQA
Copy link

SparkQA commented Oct 21, 2021

Test build #144481 has finished for PR 34315 at commit 45dc138.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 21, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48953/

@SparkQA
Copy link

SparkQA commented Oct 21, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48953/

Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
@HyukjinKwon
Copy link
Member

will merge this one in few more days if there are no more comments.

@h-vetinari
Copy link
Contributor Author

will merge this one in few more days if there are no more comments.

Sounds good, thanks for the review!

Are you planning to merge to the 3.2 branch as well? I think that would be worth a consideration given that the online docs would otherwise keep reflecting the old instructions until 3.3, which is going to take a while yet...

@SparkQA
Copy link

SparkQA commented Oct 21, 2021

Test build #144486 has finished for PR 34315 at commit e7b891f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

I think we can backport to branch-3.2 but that won't be available on Spark 3.2.0 as it's already released. So i will probably just merge it to master branch for now.

@SparkQA
Copy link

SparkQA commented Oct 21, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48958/

@h-vetinari
Copy link
Contributor Author

I think we can backport to branch-3.2 but that won't be available on Spark 3.2.0 as it's already released.

Well, 3.2.1 will presumably still arrive much sooner than 3.3.0, and then the most current docs would also be updated along with it, no?

@HyukjinKwon
Copy link
Member

Might be faster a couple of months, and improvement doesn't usually go to maintenance release by right.

@srowen
Copy link
Member

srowen commented Oct 21, 2021

A docs change like this seems ok to backport to 3.2 imho

@SparkQA
Copy link

SparkQA commented Oct 21, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48958/

@HyukjinKwon
Copy link
Member

Just wanted to more just point out the standard practice. I am good with that too for extra clarification.

@h-vetinari
Copy link
Contributor Author

Thanks both, glad to hear it! :)

Copy link
Member

@gengliangwang gengliangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. +1 to backport to the 3.2 documentation site.

@HyukjinKwon
Copy link
Member

Merged to master and branch-3.2.

HyukjinKwon pushed a commit that referenced this pull request Oct 22, 2021
### What changes were proposed in this pull request?

Improve conda installation docs

### Why are the changes needed?

As requested [here](apache/spark-website#361 (comment)). Ideally, this should be backported to the 3.2-branch (so it becomes visible for the 3.2.0 installation documentation [here](https://spark.apache.org/docs/3.2.0/api/python/getting_started/install.html)).
CC gengliangwang

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Not tested

Closes #34315 from h-vetinari/conda-install.

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 016ab0c)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
sunchao pushed a commit to sunchao/spark that referenced this pull request Dec 8, 2021
### What changes were proposed in this pull request?

Improve conda installation docs

### Why are the changes needed?

As requested [here](apache/spark-website#361 (comment)). Ideally, this should be backported to the 3.2-branch (so it becomes visible for the 3.2.0 installation documentation [here](https://spark.apache.org/docs/3.2.0/api/python/getting_started/install.html)).
CC gengliangwang

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Not tested

Closes apache#34315 from h-vetinari/conda-install.

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 016ab0c)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
catalinii pushed a commit to lyft/spark that referenced this pull request Feb 22, 2022
### What changes were proposed in this pull request?

Improve conda installation docs

### Why are the changes needed?

As requested [here](apache/spark-website#361 (comment)). Ideally, this should be backported to the 3.2-branch (so it becomes visible for the 3.2.0 installation documentation [here](https://spark.apache.org/docs/3.2.0/api/python/getting_started/install.html)).
CC gengliangwang

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Not tested

Closes apache#34315 from h-vetinari/conda-install.

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 016ab0c)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
catalinii pushed a commit to lyft/spark that referenced this pull request Mar 4, 2022
### What changes were proposed in this pull request?

Improve conda installation docs

### Why are the changes needed?

As requested [here](apache/spark-website#361 (comment)). Ideally, this should be backported to the 3.2-branch (so it becomes visible for the 3.2.0 installation documentation [here](https://spark.apache.org/docs/3.2.0/api/python/getting_started/install.html)).
CC gengliangwang

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Not tested

Closes apache#34315 from h-vetinari/conda-install.

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 016ab0c)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants