[SPARK-37561][SQL] Avoid loading all functions when obtaining hive's DelegationToken #34822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cxzl25
changed the title
|
Can one of the admins verify this patch? |
|
cc @sunchao |
HyukjinKwon
reviewed
Dec 7, 2021
| val hive = Hive.get(conf, classOf[HiveConf]) | ||
| val hive = conf match { | ||
| case hiveConf: HiveConf => | ||
| Hive.getWithoutRegisterFns(hiveConf) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok, I thought at first that code that has nothing to do with HiveClientImpl does not need to be compatible with lower versions. I also use reflection to solve compatibility problems.
sunchao
reviewed
Dec 7, 2021
| val hive = Hive.get(conf, classOf[HiveConf]) | ||
| val hive = conf match { | ||
| case hiveConf: HiveConf => | ||
| try { |
There was a problem hiding this comment.
can we reduce the code duplication by moving HiveClientImpl.getHive to its companion object and then call the method here?
sunchao
reviewed
Dec 8, 2021
|
|
||
| /** | ||
| * Initialize Hive through Configuration. | ||
| * first try to use getWithoutRegisterFns to initialize to avoid loading all functions, |
| Hive.get(hiveConf) | ||
| } | ||
| case _ => | ||
| Hive.get(conf, classOf[HiveConf]) |
There was a problem hiding this comment.
Maybe we can also call getWithoutRegisterFns for this path? by first converting the Configuration to a HiveConf.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use
Hive.getWithoutRegisterFnsinstead ofHive.getto avoid loading all permanent functions from the hive meta store.Why are the changes needed?
At present, when obtaining the delegationToken of hive, all functions will be loaded.
This is unnecessary, it takes time to load the function, and it also increases the burden on the hive meta store.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
manual test