[SPARK-37557][SQL] Replace object hash with sort aggregate if child is already sorted #34824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan could you help take a look when you have time? Thanks. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
cloud-fan
approved these changes
Dec 7, 2021
|
thanks, merging to master! |
|
Thank you @cloud-fan for review! |
|
Test build #145968 has finished for PR 34824 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow up of #34702 (comment) , where we can replace object hash aggregate with sort aggregate as well. This PR is to handle object hash aggregate.
Why are the changes needed?
Increase coverage of rule by handling object hash aggregate as well.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Modified unit test in
ReplaceHashWithSortAggSuite.scalato cover object hash aggregate (by using aggregate expressionCOLLECT_LIST).