Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-30789][SQL][DOCS][FOLLOWUP] Add document for syntax (IGNORE | RESPECT) NULLS #35079

Closed
wants to merge 8 commits into from

Conversation

beliefer
Copy link
Contributor

@beliefer beliefer commented Dec 31, 2021

What changes were proposed in this pull request?

#30943 supports syntax (IGNORE | RESPECT) NULLS for LEAD/LAG/NTH_VALUE/FIRST_VALUE/LAST_VALUE, but update document.
The screen snapshot before this PR
screenshot-20211231-174803

This PR adds document for syntax (IGNORE | RESPECT) NULLS

The screen snapshot after this PR
image

image

Why are the changes needed?

Add document for syntax (IGNORE | RESPECT) NULLS

Does this PR introduce any user-facing change?

'No'. Just update docs.

How was this patch tested?

Manual check.

@github-actions github-actions bot added the DOCS label Dec 31, 2021
@beliefer beliefer changed the title [SPARK-30789][SQL] Add document for syntax (IGNORE | RESPECT) NULLS [SPARK-30789][SQL][DOCS] Add document for syntax (IGNORE | RESPECT) NULLS Dec 31, 2021
@beliefer beliefer changed the title [SPARK-30789][SQL][DOCS] Add document for syntax (IGNORE | RESPECT) NULLS [SPARK-30789][SQL][DOCS][FOLLOWUP] Add document for syntax (IGNORE | RESPECT) NULLS Dec 31, 2021
@beliefer
Copy link
Contributor Author

beliefer commented Jan 4, 2022

ping @cloud-fan


* Aggregate Functions

**Syntax:** `MAX | MIN | COUNT | SUM | AVG | ...`

Please refer to the [Built-in Aggregation Functions](sql-ref-functions-builtin.html#aggregate-functions) document for a complete list of Spark aggregate functions.

* **nulls_option**

Specified to indicate whether skip null values in the determination of which row to use. `RESPECT NULLS` is supported by default if you do not specify `IGNORE NULLS`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifies whether or not to skip null values when evaluating the window function. RESECT NULLS means not skipping null values, while IGNORE NULLS means skipping. If not specified, the default is RESECT NULLS.


`{ IGNORE | RESPECT } NULLS`

**Note:** Only `LAG | LEAD | NTH_VALUE | FIRST_VALUE | LAST_VALUE` could append `{ IGNORE | RESPECT } NULLS`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Note:** Only `LAG | LEAD | NTH_VALUE | FIRST_VALUE | LAST_VALUE` could append `{ IGNORE | RESPECT } NULLS`.
**Note:** Only `LAG | LEAD | NTH_VALUE | FIRST_VALUE | LAST_VALUE` can be used with `IGNORE NULLS`.

@cloud-fan
Copy link
Contributor

thanks, merging to master/3.2!

@cloud-fan cloud-fan closed this in 93c614b Jan 5, 2022
cloud-fan pushed a commit that referenced this pull request Jan 5, 2022
… RESPECT) NULLS`

### What changes were proposed in this pull request?
#30943 supports syntax `(IGNORE | RESPECT) NULLS for LEAD/LAG/NTH_VALUE/FIRST_VALUE/LAST_VALUE`, but update document.
The screen snapshot before this PR
![screenshot-20211231-174803](https://user-images.githubusercontent.com/8486025/147816336-debca074-0b84-48e8-9ed2-cb13f562cf12.png)

This PR adds document for syntax `(IGNORE | RESPECT) NULLS`

The screen snapshot after this PR
![image](https://user-images.githubusercontent.com/8486025/148141568-506e9232-a3c4-4a25-a5c6-65a5d5a2e066.png)

![image](https://user-images.githubusercontent.com/8486025/148061495-b7198417-9d4c-4c03-9060-385271ea9a46.png)

### Why are the changes needed?
Add document for syntax `(IGNORE | RESPECT) NULLS`

### Does this PR introduce _any_ user-facing change?
'No'. Just update docs.

### How was this patch tested?
Manual check.

Closes #35079 from beliefer/SPARK-30789-docs.

Authored-by: Jiaan Geng <beliefer@163.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 93c614b)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
@beliefer
Copy link
Contributor Author

beliefer commented Jan 5, 2022

@cloud-fan Thank you.

catalinii pushed a commit to lyft/spark that referenced this pull request Feb 22, 2022
… RESPECT) NULLS`

### What changes were proposed in this pull request?
apache#30943 supports syntax `(IGNORE | RESPECT) NULLS for LEAD/LAG/NTH_VALUE/FIRST_VALUE/LAST_VALUE`, but update document.
The screen snapshot before this PR
![screenshot-20211231-174803](https://user-images.githubusercontent.com/8486025/147816336-debca074-0b84-48e8-9ed2-cb13f562cf12.png)

This PR adds document for syntax `(IGNORE | RESPECT) NULLS`

The screen snapshot after this PR
![image](https://user-images.githubusercontent.com/8486025/148141568-506e9232-a3c4-4a25-a5c6-65a5d5a2e066.png)

![image](https://user-images.githubusercontent.com/8486025/148061495-b7198417-9d4c-4c03-9060-385271ea9a46.png)

### Why are the changes needed?
Add document for syntax `(IGNORE | RESPECT) NULLS`

### Does this PR introduce _any_ user-facing change?
'No'. Just update docs.

### How was this patch tested?
Manual check.

Closes apache#35079 from beliefer/SPARK-30789-docs.

Authored-by: Jiaan Geng <beliefer@163.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 93c614b)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
catalinii pushed a commit to lyft/spark that referenced this pull request Mar 4, 2022
… RESPECT) NULLS`

### What changes were proposed in this pull request?
apache#30943 supports syntax `(IGNORE | RESPECT) NULLS for LEAD/LAG/NTH_VALUE/FIRST_VALUE/LAST_VALUE`, but update document.
The screen snapshot before this PR
![screenshot-20211231-174803](https://user-images.githubusercontent.com/8486025/147816336-debca074-0b84-48e8-9ed2-cb13f562cf12.png)

This PR adds document for syntax `(IGNORE | RESPECT) NULLS`

The screen snapshot after this PR
![image](https://user-images.githubusercontent.com/8486025/148141568-506e9232-a3c4-4a25-a5c6-65a5d5a2e066.png)

![image](https://user-images.githubusercontent.com/8486025/148061495-b7198417-9d4c-4c03-9060-385271ea9a46.png)

### Why are the changes needed?
Add document for syntax `(IGNORE | RESPECT) NULLS`

### Does this PR introduce _any_ user-facing change?
'No'. Just update docs.

### How was this patch tested?
Manual check.

Closes apache#35079 from beliefer/SPARK-30789-docs.

Authored-by: Jiaan Geng <beliefer@163.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 93c614b)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
kazuyukitanimura pushed a commit to kazuyukitanimura/spark that referenced this pull request Aug 10, 2022
… RESPECT) NULLS`

### What changes were proposed in this pull request?
apache#30943 supports syntax `(IGNORE | RESPECT) NULLS for LEAD/LAG/NTH_VALUE/FIRST_VALUE/LAST_VALUE`, but update document.
The screen snapshot before this PR
![screenshot-20211231-174803](https://user-images.githubusercontent.com/8486025/147816336-debca074-0b84-48e8-9ed2-cb13f562cf12.png)

This PR adds document for syntax `(IGNORE | RESPECT) NULLS`

The screen snapshot after this PR
![image](https://user-images.githubusercontent.com/8486025/148141568-506e9232-a3c4-4a25-a5c6-65a5d5a2e066.png)

![image](https://user-images.githubusercontent.com/8486025/148061495-b7198417-9d4c-4c03-9060-385271ea9a46.png)

### Why are the changes needed?
Add document for syntax `(IGNORE | RESPECT) NULLS`

### Does this PR introduce _any_ user-facing change?
'No'. Just update docs.

### How was this patch tested?
Manual check.

Closes apache#35079 from beliefer/SPARK-30789-docs.

Authored-by: Jiaan Geng <beliefer@163.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 93c614b)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 9b6be1a)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants