[SPARK-38521][SQL] Throw Exception if overwriting hive partition table with dynamic and staticPartitionOverwriteMode #35815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…staticPartitionOverwriteMode
jackylee-ch
commented
Mar 11, 2022
| @@ -234,7 +237,7 @@ case class InsertIntoHadoopFsRelationCommand( | |||
| if (fs.exists(staticPrefixPath) && !committer.deleteWithJob(fs, staticPrefixPath, true)) { | |||
| throw QueryExecutionErrors.cannotClearOutputDirectoryError(staticPrefixPath) | |||
| } | |||
| // now clear all custom partition locations (e.g. /custom/dir/where/foo=2/bar=4) | |||
| // now clear custom static partition locations (e.g. /custom/dir/where/foo=1) | |||
There was a problem hiding this comment.
This is changed because after this PR, only overwriting the static partition will run into deleteMatchingPartitions.
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The
spark.sql.sources.partitionOverwriteModeallows us to overwrite the existing data of the table through staticmode, but for hive table, it is disastrous. It may deleting all data in hive partitioned table while writing with dynamic overwrite andpartitionOverwriteMode=STATIC.Here we add a check for this and throw Exception if this happends.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
Add new ut