[SPARK-39234][SQL] Code clean up in SparkThrowableHelper.getMessage #36612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6cdcbda.
gengliangwang
commented
May 19, 2022
| errorInfo.messageFormat + errorSubInfo.messageFormat) | ||
| } | ||
| val displayMessage = String.format( | ||
| displayFormat.replaceAll("<[a-zA-Z0-9_-]+>", "%s"), |
There was a problem hiding this comment.
Here we avoid writing .replaceAll("<[a-zA-Z0-9_-]+>", "%s") twice
cloud-fan
approved these changes
May 19, 2022
MaxGekk
approved these changes
May 19, 2022
|
+1, LGTM. Merging to master. |
gengliangwang
added a commit
to gengliangwang/spark
that referenced
this pull request
May 25, 2022
1. Remove the starting "\n" in `Origin.context`. The "\n" will be append in the method `SparkThrowableHelper.getMessage` instead. 2. Code clean up the method SparkThrowableHelper.getMessage to eliminate redundant code. Code clean up to eliminate redundant code. No Existing UT Closes apache#36612 from gengliangwang/moveNewLine. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Origin.context. The "\n" will be append in the methodSparkThrowableHelper.getMessageinstead.Why are the changes needed?
Code clean up to eliminate redundant code.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT