Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-39617][CORE] Driver cores mult be a positive number fix #37016

Closed
wants to merge 2 commits into from
Closed

[SPARK-39617][CORE] Driver cores mult be a positive number fix #37016

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ebc806
Parse number as Double first
talecsander Jun 29, 2022
ac5719c
rebuild
talecsander Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ private[deploy] class SparkSubmitArguments(args: Seq[String], env: Map[String, S
&& Try(JavaUtils.byteStringAsBytes(executorMemory)).getOrElse(-1L) <= 0) {
error("Executor memory must be a positive number")
}
if (driverCores != null && Try(driverCores.toInt).getOrElse(-1) <= 0) {
if (driverCores != null && Try(driverCores.toDouble.toInt).getOrElse(-1) <= 0) {
error("Driver cores must be a positive number")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should be improved properly by pattern matching on the Try and printing the actual Failure.
Not just for driverCores but for all input arguments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to do that in general, but IMHO, in this case, the message is very easy to understand, and also I'd rather keep it consistent with the other checks..

}
if (executorCores != null && Try(executorCores.toInt).getOrElse(-1) <= 0) {
Expand Down