-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-37287][SQL][FOLLOWUP] Only apply AQE on top of V1 write commands when planned write is enabled #37308
Closed
allisonwang-db
wants to merge
2
commits into
apache:master
from
allisonwang-db:spark-37287-follow-up
Closed
[SPARK-37287][SQL][FOLLOWUP] Only apply AQE on top of V1 write commands when planned write is enabled #37308
allisonwang-db
wants to merge
2
commits into
apache:master
from
allisonwang-db:spark-37287-follow-up
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed test:
|
cc @cloud-fan |
cloud-fan
approved these changes
Jul 28, 2022
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a follow-up for SPARK-37287. We only want to apply AQE on top of V1 write commands when the planned write config is enabled.
Why are the changes needed?
To make the behavior consistent with before when
spark.sql.optimizer.plannedWrite.enabled
is disabled.Does this PR introduce any user-facing change?
No
How was this patch tested?
New unit test.