[SPARK-42239][SQL][3.4] Integrate MUST_AGGREGATE_CORRELATED_SCALAR_SUBQUERY
#39831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changes were proposed in this pull request? This is raised from https://github.com/apache/spark/pull/39543/files#r1082159637, to integrate the `MUST_AGGREGATE_CORRELATED_SCALAR_SUBQUERY` and `MUST_AGGREGATE_CORRELATED_SCALAR_SUBQUERY_OUTPUT` ### Why are the changes needed? Logically, `MUST_AGGREGATE_CORRELATED_SCALAR_SUBQUERY` and `MUST_AGGREGATE_CORRELATED_SCALAR_SUBQUERY_OUTPUT` are exactly the same. We should deduplicate the error classes when possible. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Updated the existing UT. Closes apache#39806 from itholic/MUST_AGGREGATE_CORRELATED_SCALAR_SUBQUERY1. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
itholic
changed the title
MUST_AGGREGATE_CORRELATED_SCALAR_SUBQUERYMUST_AGGREGATE_CORRELATED_SCALAR_SUBQUERY
|
+1, LGTM. Merging to 3.4. |
MaxGekk
pushed a commit
that referenced
this pull request
Feb 1, 2023
…UBQUERY` ### What changes were proposed in this pull request? backport for #39806 ### Why are the changes needed? We should want to include PRs related to error classes into Spark 3.4. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The CI should pass. Closes #39831 from itholic/42239-3.4. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
itholic
changed the title
MUST_AGGREGATE_CORRELATED_SCALAR_SUBQUERYMUST_AGGREGATE_CORRELATED_SCALAR_SUBQUERY
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…UBQUERY` ### What changes were proposed in this pull request? backport for apache#39806 ### Why are the changes needed? We should want to include PRs related to error classes into Spark 3.4. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The CI should pass. Closes apache#39831 from itholic/42239-3.4. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
backport for #39806
Why are the changes needed?
We should want to include PRs related to error classes into Spark 3.4.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The CI should pass.