-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-5158] [core] [security] Spark standalone mode can authenticate against a Kerberos-secured Hadoop cluster #4106
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
core/src/main/scala/org/apache/spark/deploy/StandaloneSparkHadoopUtil.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.deploy | ||
|
||
import java.security.PrivilegedAction | ||
|
||
import org.apache.hadoop.conf.Configuration | ||
import org.apache.hadoop.mapred.JobConf | ||
import org.apache.hadoop.security.UserGroupInformation | ||
import org.apache.spark.{SparkConf, SparkEnv, Logging} | ||
import sun.security.jgss.krb5.Krb5InitCredential | ||
|
||
import scala.sys.process.Process | ||
|
||
private[spark] class StandaloneSparkHadoopUtil extends SparkHadoopUtil { | ||
|
||
val hadoopSecurityAuthenticationKey = "spark.hadoop.security.authentication" | ||
val principalKey = "spark.hadoop.dfs.namenode.kerberos.principal" | ||
val keytabKey = "spark.hadoop.dfs.namenode.keytab.file" | ||
val securityEnabledButKeyNotDefined = "Hadoop security was enabled, but %s" + | ||
"was not set in the Spark configuration." | ||
|
||
// Lazily evaluated upon invoking loginAsSparkUserAndReturnUGI() | ||
lazy val loggedInUser: UserGroupInformation = { | ||
val authenticationType = SparkEnv.get.conf.get(hadoopSecurityAuthenticationKey, "simple") | ||
if (authenticationType.equalsIgnoreCase("kerberos")) { | ||
logInfo("Setting up kerberos to authenticate") | ||
SparkEnv.get.conf.getOption(principalKey) match { | ||
case Some(principal) => | ||
SparkEnv.get.conf.getOption(keytabKey) match { | ||
case Some(keytab) => | ||
UserGroupInformation.setConfiguration(newConfiguration(SparkEnv.get.conf)) | ||
loginUserFromKeytab(principal, keytab) | ||
UserGroupInformation.getLoginUser() | ||
case None => | ||
val errorMsg = securityEnabledButKeyNotDefined.format(keytabKey) | ||
logError(errorMsg) | ||
throw new IllegalStateException(errorMsg) | ||
} | ||
case None => | ||
val errorMsg = securityEnabledButKeyNotDefined.format(principalKey) | ||
logError(errorMsg) | ||
throw new IllegalStateException(errorMsg) | ||
} | ||
} else { | ||
logInfo("Not using Kerberos to authenticate to Hadoop.") | ||
UserGroupInformation.getCurrentUser() | ||
} | ||
} | ||
override def getAuthenticatedUgiForSparkUser(user: String): UserGroupInformation = { | ||
UserGroupInformation.createProxyUser(user, loginAsSparkUserAndReturnUGI()) | ||
} | ||
|
||
override def loginAsSparkUser() { | ||
loginAsSparkUserAndReturnUGI() | ||
} | ||
|
||
private def loginAsSparkUserAndReturnUGI(): UserGroupInformation = loggedInUser | ||
|
||
override def newConfiguration(sparkConf: SparkConf): Configuration = { | ||
val originalConf = super.newConfiguration(sparkConf) | ||
originalConf.set("hadoop.security.authentication", | ||
sparkConf.get(hadoopSecurityAuthenticationKey, "simple")) | ||
originalConf | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -125,39 +125,39 @@ private[spark] object CoarseGrainedExecutorBackend extends Logging { | |
|
||
SignalLogger.register(log) | ||
|
||
SparkHadoopUtil.get.runAsSparkUser { () => | ||
// Debug code | ||
Utils.checkHost(hostname) | ||
|
||
// Bootstrap to fetch the driver's Spark properties. | ||
val executorConf = new SparkConf | ||
val port = executorConf.getInt("spark.executor.port", 0) | ||
val (fetcher, _) = AkkaUtils.createActorSystem( | ||
"driverPropsFetcher", | ||
hostname, | ||
port, | ||
executorConf, | ||
new SecurityManager(executorConf)) | ||
val driver = fetcher.actorSelection(driverUrl) | ||
val timeout = AkkaUtils.askTimeout(executorConf) | ||
val fut = Patterns.ask(driver, RetrieveSparkProps, timeout) | ||
val props = Await.result(fut, timeout).asInstanceOf[Seq[(String, String)]] ++ | ||
Seq[(String, String)](("spark.app.id", appId)) | ||
fetcher.shutdown() | ||
|
||
// Create SparkEnv using properties we fetched from the driver. | ||
val driverConf = new SparkConf() | ||
for ((key, value) <- props) { | ||
// this is required for SSL in standalone mode | ||
if (SparkConf.isExecutorStartupConf(key)) { | ||
driverConf.setIfMissing(key, value) | ||
} else { | ||
driverConf.set(key, value) | ||
} | ||
// Debug code | ||
Utils.checkHost(hostname) | ||
|
||
// Bootstrap to fetch the driver's Spark properties. | ||
val executorConf = new SparkConf | ||
val port = executorConf.getInt("spark.executor.port", 0) | ||
val (fetcher, _) = AkkaUtils.createActorSystem( | ||
"driverPropsFetcher", | ||
hostname, | ||
port, | ||
executorConf, | ||
new SecurityManager(executorConf)) | ||
val driver = fetcher.actorSelection(driverUrl) | ||
val timeout = AkkaUtils.askTimeout(executorConf) | ||
val fut = Patterns.ask(driver, RetrieveSparkProps, timeout) | ||
val props = Await.result(fut, timeout).asInstanceOf[Seq[(String, String)]] ++ | ||
Seq[(String, String)](("spark.app.id", appId)) | ||
fetcher.shutdown() | ||
|
||
// Create SparkEnv using properties we fetched from the driver. | ||
val driverConf = new SparkConf() | ||
for ((key, value) <- props) { | ||
// this is required for SSL in standalone mode | ||
if (SparkConf.isExecutorStartupConf(key)) { | ||
driverConf.setIfMissing(key, value) | ||
} else { | ||
driverConf.set(key, value) | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please double check my merge here. |
||
val env = SparkEnv.createExecutorEnv( | ||
driverConf, executorId, hostname, port, cores, isLocal = false) | ||
} | ||
val env = SparkEnv.createExecutorEnv( | ||
driverConf, executorId, hostname, port, cores, isLocal = false) | ||
|
||
SparkHadoopUtil.get.runAsSparkUser { () => | ||
// SparkEnv sets spark.driver.port so it shouldn't be 0 anymore. | ||
val boundPort = env.conf.getInt("spark.executor.port", 0) | ||
assert(boundPort != 0) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, this doesn't have to be lazy