Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-44041][BUILD] Upgrade Ammonite to 2.5.9 #41624

Closed
wants to merge 1 commit into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Jun 16, 2023

What changes were proposed in this pull request?

This pr is aim to upgrade ammonite from 2.5.8 to 2.5.9.

Why are the changes needed?

Ammonite 2.5.9 is used to support Scala 2.12.18 and Scala 2.13.11:

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GitHub Actions

@LuciferYang
Copy link
Contributor Author

Test first

@github-actions github-actions bot added the BUILD label Jun 16, 2023
@LuciferYang
Copy link
Contributor Author

cc @dongjoon-hyun FYI

@LuciferYang LuciferYang changed the title [SPARK-44041][BUILD] Upgrade ammonite to 2.5.9 [SPARK-44041][BUILD] Upgrade Ammonite to 2.5.9 Jun 16, 2023
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! It's great!

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs).

@dongjoon-hyun
Copy link
Member

Merged to master!

@LuciferYang
Copy link
Contributor Author

Thanks @dongjoon-hyun ~

czxm pushed a commit to czxm/spark that referenced this pull request Jun 19, 2023
### What changes were proposed in this pull request?
This pr is aim to upgrade ammonite from 2.5.8 to 2.5.9.

### Why are the changes needed?
Ammonite 2.5.9  is used to support Scala 2.12.18 and Scala 2.13.11:
- com-lihaoyi/Ammonite@2.5.8...2.5.9

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass GitHub Actions

Closes apache#41624 from LuciferYang/SPARK-44041.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Aug 7, 2024
This pr is aim to upgrade ammonite from 2.5.8 to 2.5.9.

Ammonite 2.5.9  is used to support Scala 2.12.18 and Scala 2.13.11:
- com-lihaoyi/Ammonite@2.5.8...2.5.9

No

Pass GitHub Actions

Closes apache#41624 from LuciferYang/SPARK-44041.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants