-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-44041][BUILD] Upgrade Ammonite to 2.5.9 #41624
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test first |
cc @dongjoon-hyun FYI |
LuciferYang
changed the title
[SPARK-44041][BUILD] Upgrade ammonite to 2.5.9
[SPARK-44041][BUILD] Upgrade Ammonite to 2.5.9
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally! It's great!
dongjoon-hyun
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM (Pending CIs).
Merged to master! |
Thanks @dongjoon-hyun ~ |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 19, 2023
### What changes were proposed in this pull request? This pr is aim to upgrade ammonite from 2.5.8 to 2.5.9. ### Why are the changes needed? Ammonite 2.5.9 is used to support Scala 2.12.18 and Scala 2.13.11: - com-lihaoyi/Ammonite@2.5.8...2.5.9 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions Closes apache#41624 from LuciferYang/SPARK-44041. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Aug 7, 2024
This pr is aim to upgrade ammonite from 2.5.8 to 2.5.9. Ammonite 2.5.9 is used to support Scala 2.12.18 and Scala 2.13.11: - com-lihaoyi/Ammonite@2.5.8...2.5.9 No Pass GitHub Actions Closes apache#41624 from LuciferYang/SPARK-44041. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr is aim to upgrade ammonite from 2.5.8 to 2.5.9.
Why are the changes needed?
Ammonite 2.5.9 is used to support Scala 2.12.18 and Scala 2.13.11:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions