[SPARK-40497][BUILD] Upgrade Scala to 2.13.11 #41626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
Jun 16, 2023
|
Test first |
There was a problem hiding this comment.
BTW, did you have a chance to check the reported issues mentioned by Jungtaek, @LuciferYang ?
OK, let me check this |
LuciferYang
commented
Jun 17, 2023
.github/workflows/build_and_test.yml
Outdated
| @@ -190,6 +190,7 @@ jobs: | |||
| HIVE_PROFILE: ${{ matrix.hive }} | |||
| GITHUB_PREV_SHA: ${{ github.event.before }} | |||
| SPARK_LOCAL_IP: localhost | |||
| SCALA_PROFILE: scala2.13 | |||
There was a problem hiding this comment.
will revert after test
|
dc4def0 test Java8 + Scala 2.13, all test passed. |
LuciferYang
commented
Jun 17, 2023
.github/workflows/build_and_test.yml
Outdated
| @@ -25,7 +25,7 @@ on: | |||
| java: | |||
| required: false | |||
| type: string | |||
| default: 8 | |||
| default: 17 | |||
There was a problem hiding this comment.
try to test Java 17 + Scala 2.13.11, will revert later
|
https://github.com/LuciferYang/spark/actions/runs/5298355546/jobs/9595559054 
Java 17 + Scala 2.13 all test passed |
|
revert change of build_and_test.yml |
|
I will do more check tomorrow and update pr description, seems is a available new version for now. |
|
@dongjoon-hyun @HyukjinKwon I think it's ok to upgrade to Scala 2.13.11 for Spark |
dongjoon-hyun
approved these changes
Jun 19, 2023
|
Thanks @dongjoon-hyun |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 19, 2023
### What changes were proposed in this pull request? This PR aims to upgrade Scala to 2.13.11 - https://www.scala-lang.org/news/2.13.11 Additionally, this pr adds a new suppression rule for warning message: `Implicit definition should have explicit type`, this is a new compile check introduced by scala/scala#10083, we must fix it when we upgrading to use Scala 3, ### Why are the changes needed? This release improves collections, adds support for JDK 20 and 21, adds support for JDK 17 `sealed`: - scala/scala#10363 - scala/scala#10184 - scala/scala#10397 - scala/scala#10348 - scala/scala#10105 There are 2 known issues in this version: - scala/bug#12800 - scala/bug#12799 For the first one, there is no compilation warning messages related to `match may not be exhaustive` in Spark compile log, and for the second one, there is no case of `method.isAnnotationPresent(Deprecated.class)` in Spark code, there is just https://github.com/apache/spark/blob/8c84d2c9349d7b607db949c2e114df781f23e438/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala#L130 in Spark Code, and I checked `javax.annotation.Nonnull` no this issue. So I think These two issues will not affect Spark itself, but this doesn't mean it won't affect the code written by end users themselves The full release notes as follows: - https://github.com/scala/scala/releases/tag/v2.13.11 ### Does this PR introduce _any_ user-facing change? Yes, this is a Scala version change. ### How was this patch tested? - Existing Test - Checked Java 8/17 + Scala 2.13.11 using GA, all test passed Java 8 + Scala 2.13.11: https://github.com/LuciferYang/spark/runs/14337279564 Java 17 + Scala 2.13.11: https://github.com/LuciferYang/spark/runs/14343012195 Closes apache#41626 from LuciferYang/SPARK-40497. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Thank you always, @LuciferYang ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade Scala to 2.13.11
Additionally, this pr adds a new suppression rule for warning message:
Implicit definition should have explicit type, this is a new compile check introduced by scala/scala#10083, we must fix it when we upgrading to use Scala 3,Why are the changes needed?
This release improves collections, adds support for JDK 20 and 21, adds support for JDK 17
sealed:sealedin Java sources scala/scala#10348PermittedSubclassesin classfiles scala/scala#10105There are 2 known issues in this version:
@Deprecatedannotations when extending Java interface with deprecated default method causejava.lang.annotation.AnnotationFormatErrorwhen accessed via Java reflection (2.13.11 regression) scala/bug#12799For the first one, there is no compilation warning messages related to
match may not be exhaustivein Spark compile log, and for the second one, there is no case ofmethod.isAnnotationPresent(Deprecated.class)in Spark code, there is justspark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala
Line 130 in 8c84d2c
in Spark Code, and I checked
@javax.annotation.Nonnullno this issue.So I think These two issues will not affect Spark itself, but this doesn't mean it won't affect the code written by end users themselves
The full release notes as follows:
Does this PR introduce any user-facing change?
Yes, this is a Scala version change.
How was this patch tested?
Java 8 + Scala 2.13.11: https://github.com/LuciferYang/spark/runs/14337279564
Java 17 + Scala 2.13.11: https://github.com/LuciferYang/spark/runs/14343012195