[SPARK-43656][CONNECT][PS][TESTS] Enable numpy compat tests for Spark Connect #43214
+4
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This functionality works fine in manual testing with Python interpreter: >>> spark # check if the current session is Spark Connect session.
<pyspark.sql.connect.session.SparkSession object at 0x105b3fbe0>
>>> import pyspark.pandas as ps
>>> import numpy as np
>>> psdf = ps.DataFrame({"A": [1, 2, 3]})
>>> np_name = "arccosh"
>>> np_func = getattr(np, np_name)
>>> np_func(psdf)
A
0 0.000000
1 1.316958
2 1.762747But failed in UT: spark % python/run-tests --testnames 'pyspark.pandas.tests.connect.test_parity_numpy_compat NumPyCompatParityTests.test_np_spark_compat_frame'
...
======================================================================
FAIL [3.103s]: test_np_spark_compat_frame (pyspark.pandas.tests.connect.test_parity_numpy_compat.NumPyCompatParityTests)
----------------------------------------------------------------------
...
pyspark.errors.exceptions.base.PySparkTypeError: [NOT_COLUMN_OR_STR] Argument `col` should be a Column or str, got Column.
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
...
AssertionError: Test in 'arccosh' function was failed.
----------------------------------------------------------------------
Ran 1 test in 5.956sLet me test how it works on GitHub Actions. |
itholic
commented
Oct 5, 2023
| @@ -20,7 +20,6 @@ | |||
|
|
|||
| from pyspark import pandas as ps | |||
| from pyspark.pandas import set_option, reset_option | |||
| from pyspark.pandas.numpy_compat import unary_np_spark_mappings, binary_np_spark_mappings | |||
There was a problem hiding this comment.
Some lines of numpy_compat.py call pandas_udf which uses is_remote() internally, so we should import numpy_compat after initializing the Spark Connect properly when testing.
itholic
changed the title
zhengruifeng
changed the title
zhengruifeng
approved these changes
Oct 5, 2023
HyukjinKwon
approved these changes
Oct 5, 2023
|
merged to master |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
Oct 7, 2023
… Connect ### What changes were proposed in this pull request? This PR proposes to enable `test_np_spark_compat_frame` and `test_np_spark_compat_series` for Spark Connect. ### Why are the changes needed? To increase test coverage ### Does this PR introduce _any_ user-facing change? No, it's test-only. ### How was this patch tested? The existing tests should pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#43214 from itholic/SPARK-43656. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to enable
test_np_spark_compat_frameandtest_np_spark_compat_seriesfor Spark Connect.Why are the changes needed?
To increase test coverage
Does this PR introduce any user-facing change?
No, it's test-only.
How was this patch tested?
The existing tests should pass.
Was this patch authored or co-authored using generative AI tooling?
No.