[SPARK-45486][CONNECT] Make add_artifact request idempotent #43314
+50
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @grundprinzip, @HyukjinKwon -- (same change as previously discussed). |
HyukjinKwon
approved these changes
Oct 10, 2023
grundprinzip
approved these changes
Oct 11, 2023
|
Mind retriggering the failed tests https://github.com/cdkrot/apache_spark/runs/17602108213 ? |
|
Retriggered, thanks! |
MaxGekk
reviewed
Oct 12, 2023
| @@ -82,6 +83,40 @@ class SparkConnectArtifactManager(sessionHolder: SessionHolder) extends Logging | |||
| */ | |||
| def getSparkConnectPythonIncludes: Seq[String] = pythonIncludeList.asScala.toSeq | |||
|
|
|||
| private def areFilesEqual(path1: Path, path2: Path): Boolean = { | |||
There was a problem hiding this comment.
Can't you re-use some functions from libs like Apache Common: IOUtils::contentEquals or FileUtils.contentEquals. Or there is some reason to don't do that. Please, clarify that.
There was a problem hiding this comment.
That sounds good, let me see if we can use it
There was a problem hiding this comment.
Added this, thanks for the feedback!
HyukjinKwon
approved these changes
Oct 16, 2023
|
Merged to master. |
|
The JIRA number was wrong. Let me switch the JIRA with SPARK-45486 |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 16, 2024
### What changes were proposed in this pull request? Make addArtifact API retrying on errors. Note this is safe operation since addArtifact is idempotent operation (#43314) ### Why are the changes needed? For the same reasons as we make other API retryable. ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? Added test. Testing by hand against custom spark server. ### Was this patch authored or co-authored using generative AI tooling? No & never Closes #44740 from cdkrot/SPARK-46723-addartifact. Authored-by: Alice Sayutina <alice.sayutina@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Before the update the error looks like that
Now it looks:
Why are the changes needed?
Makes retrying more robust, adds user-friendly error (see above).
Does this PR introduce any user-facing change?
Mostly internal improvements
How was this patch tested?
Unit testing, testing against server
Was this patch authored or co-authored using generative AI tooling?
No