[SPARK-47000][CORE] Use getTotalMemorySize in WorkerArguments
#45060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review this when you have some time, @sunchao ? |
|
Thank you , @sunchao ! |
|
All tests passed. Merged to master for Apache Spark 4.0.0. |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Mar 26, 2024
### What changes were proposed in this pull request? This PR aims to use `getTotalMemorySize` instead of deprecated `getTotalPhysicalMemorySize` (OpenJDK) or `getTotalPhysicalMemory` (IBM Java) in `WorkerArguments`. ### Why are the changes needed? `getTotalPhysicalMemorySize` is deprecated at Java 14 in OpenJDK. - https://docs.oracle.com/en/java/javase/17/docs/api/jdk.management/com/sun/management/OperatingSystemMXBean.html#getTotalPhysicalMemorySize() `getTotalPhysicalMemory` is deprecated since 1.8 in IBM. - https://eclipse.dev/openj9/docs/api/jdk17/jdk.management/com/ibm/lang/management/OperatingSystemMXBean.html#getTotalPhysicalMemory() `getTotalMemorySize` is recommended in both environments for Apache Spark 4.0.0 because the minimum Java version is 17. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs with the existing test cases. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45060 from dongjoon-hyun/SPARK-47000. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
getTotalMemorySizeinstead of deprecatedgetTotalPhysicalMemorySize(OpenJDK) orgetTotalPhysicalMemory(IBM Java) inWorkerArguments.Why are the changes needed?
getTotalPhysicalMemorySizeis deprecated at Java 14 in OpenJDK.getTotalPhysicalMemoryis deprecated since 1.8 in IBM.getTotalMemorySizeis recommended in both environments for Apache Spark 4.0.0 because the minimum Java version is 17.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs with the existing test cases.
Was this patch authored or co-authored using generative AI tooling?
No.