-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-45527][CORE][TESTS][FOLLOW-UP] Reduce the number of test cases in fraction resource calculation #45272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in fraction resource calculation
@dongjoon-hyun I am sorry. This PR fixes the leftover. |
dongjoon-hyun
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great~
I verified manually. Merged to master. |
HyukjinKwon
added a commit
that referenced
this pull request
Feb 28, 2024
…e, and reduce the resource usage ### What changes were proposed in this pull request? This PR is a followup of #45272, #45268, #45264 and #45283 that increase timeout more and decrease the resource needed during the CI. ### Why are the changes needed? To make the scheduled build pass https://github.com/apache/spark/actions/runs/8054862135/job/22053180441. At least as far as I can tell, those changes are effective (makes tests less flaky and less fail). ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? I manually ran then via IDE. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45297 from HyukjinKwon/SPARK-47185-SPARK-47181-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
TakawaAkirayo
pushed a commit
to TakawaAkirayo/spark
that referenced
this pull request
Mar 4, 2024
… in fraction resource calculation ### What changes were proposed in this pull request? There are two more instances to fix in apache#45268 mistakenly missed. This PR fixes both. ### Why are the changes needed? See apache#45268 ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45272 from HyukjinKwon/SPARK-45527-followup2. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
TakawaAkirayo
pushed a commit
to TakawaAkirayo/spark
that referenced
this pull request
Mar 4, 2024
…e, and reduce the resource usage ### What changes were proposed in this pull request? This PR is a followup of apache#45272, apache#45268, apache#45264 and apache#45283 that increase timeout more and decrease the resource needed during the CI. ### Why are the changes needed? To make the scheduled build pass https://github.com/apache/spark/actions/runs/8054862135/job/22053180441. At least as far as I can tell, those changes are effective (makes tests less flaky and less fail). ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? I manually ran then via IDE. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45297 from HyukjinKwon/SPARK-47185-SPARK-47181-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
… in fraction resource calculation ### What changes were proposed in this pull request? There are two more instances to fix in apache#45268 mistakenly missed. This PR fixes both. ### Why are the changes needed? See apache#45268 ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45272 from HyukjinKwon/SPARK-45527-followup2. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
…e, and reduce the resource usage ### What changes were proposed in this pull request? This PR is a followup of apache#45272, apache#45268, apache#45264 and apache#45283 that increase timeout more and decrease the resource needed during the CI. ### Why are the changes needed? To make the scheduled build pass https://github.com/apache/spark/actions/runs/8054862135/job/22053180441. At least as far as I can tell, those changes are effective (makes tests less flaky and less fail). ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? I manually ran then via IDE. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45297 from HyukjinKwon/SPARK-47185-SPARK-47181-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are two more instances to fix in #45268 mistakenly missed. This PR fixes both.
Why are the changes needed?
See #45268
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Manually
Was this patch authored or co-authored using generative AI tooling?
No.