[SPARK-46761][SQL] Quoted strings in a JSON path should support ? characters #45420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
approved these changes
Mar 13, 2024
|
cc @HyukjinKwon |
HyukjinKwon
approved these changes
Mar 13, 2024
|
Merged to master. |
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
…racters
### What changes were proposed in this pull request?
If there is a JSON with a ? character in the key like
```
{"?":"QUESTION"}
```
This PR allow to add this character in the JSON path
```
get_json_object(json, '$['?']')
```
This character is now explicitly avoided in the regular expression but there seem to be no restrictions on this in the specification (https://goessner.net/articles/JsonPath/) and no tests fail with this change.
### Why are the changes needed?
Improve the support of ? character in json parh
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit testing
### Was this patch authored or co-authored using generative AI tooling?
No
Closes apache#45420 from planga82/bugfix/spark46761_json_path_question_mark.
Authored-by: Pablo Langa <soypab@gmail.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If there is a JSON with a ? character in the key like
This PR allow to add this character in the JSON path
This character is now explicitly avoided in the regular expression but there seem to be no restrictions on this in the specification (https://goessner.net/articles/JsonPath/) and no tests fail with this change.
Why are the changes needed?
Improve the support of ? character in json parh
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit testing
Was this patch authored or co-authored using generative AI tooling?
No